Closed parkeyparker closed 1 year ago
Hey, thanks @parkeyparker. We'll take a look at this when we can.
Any updates on this PR? Recent changes to Volar (Vue extension for VSCode) show an error for the font awesome component and this PR fixes that.
I've rebased my changes onto the latest code on the 3.x branch which should hopefully make it ready for review and merge. Any issues please let me know and I'll get them addressed as quick as I can.
This is open since April... Our project build breaks due to this. What's stopping you from merging?
Pleeeease merge this!
What's stopping you from merging?
FontAwesomeIcon
and other components needed to be of typeDefineComponent
for Vue 3 Composition API TypeScript support (as per #276). The type definitions for the component props also needed updating to denote required and optional props.Whilst checking which props were required it was noted that the
FontAwesomeLayer
component usesfixedWidth
but the README and example usefull-width
so these have been updated to match the component code.