search

FortAwesome / vue-fontawesome

Font Awesome Vue component
https://fontawesome.com
MIT License
2.39k stars 132 forks source link

fix: Type definitions for Vue 3 Composition API #355

Closed parkeyparker closed 1 year ago

parkeyparker commented 2 years ago

FontAwesomeIcon and other components needed to be of type DefineComponent for Vue 3 Composition API TypeScript support (as per #276). The type definitions for the component props also needed updating to denote required and optional props.

Whilst checking which props were required it was noted that the FontAwesomeLayer component uses fixedWidth but the README and example use full-width so these have been updated to match the component code.

robmadole commented 2 years ago

Hey, thanks @parkeyparker. We'll take a look at this when we can.

nielsvanvelzen commented 1 year ago

Any updates on this PR? Recent changes to Volar (Vue extension for VSCode) show an error for the font awesome component and this PR fixes that.

parkeyparker commented 1 year ago

I've rebased my changes onto the latest code on the 3.x branch which should hopefully make it ready for review and merge. Any issues please let me know and I'll get them addressed as quick as I can.

datrinh commented 1 year ago

This is open since April... Our project build breaks due to this. What's stopping you from merging?

plehnen commented 1 year ago

Pleeeease merge this!

dalirnet commented 1 year ago

What's stopping you from merging?