FortAwesome / vue-fontawesome

Font Awesome Vue component
https://fontawesome.com
MIT License
2.39k stars 132 forks source link

Typescript error in Nuxt 3 integration #400

Closed cmitjans-at-wiris closed 1 year ago

cmitjans-at-wiris commented 1 year ago

Describe the bug Followed the steps on how to integrate FontAwesome with Nuxt 3.

It seems the steps are not correct. I get an error when adding FontAwesomeIcon to vueApp. image

When removing the last parameter (as you would do when integrating FontAwesome with Vue 3 directly - no Nuxt) the following error shows:

image

View Problem ``` Argument of type 'ComponentPublicInstance>' is not assignable to parameter of type 'Component'. Type 'ComponentPublicInstance>' is not assignable to type 'ComponentOptions'. Type 'ComponentPublicInstance>' is not assignable to type 'ComponentOptionsBase'. Types of property 'computed' are incompatible. Type '{ (getter: ComputedGetter, debugOptions?: DebuggerOptions): ComputedRef; (options: WritableComputedOptions, debugOptions?: DebuggerOptions): WritableComputedRef<...>; }' is not assignable to type 'ComputedOptions'. Index signature for type 'string' is missing in type '{ (getter: ComputedGetter, debugOptions?: DebuggerOptions): ComputedRef; (options: WritableComputedOptions, debugOptions?: DebuggerOptions): WritableComputedRef<...>; }'.ts(2345) ```

Expected behavior There should be no typescript errors.

Additional context Dependencies I'm using:

  "dependencies": {
    "@fortawesome/fontawesome-svg-core": "^6.2.0",
    "@fortawesome/free-solid-svg-icons": "^6.2.0",
    "@fortawesome/vue-fontawesome": "^3.0.1"
  }
robmadole commented 1 year ago

Thanks @cmitjans-at-wiris we'll take a look when we can.

jonatandorozco commented 1 year ago

Any update on this?

technatelogy commented 1 year ago

This looks like it's happened before and the workaround here worked for me:

295

tobiasdiez commented 1 year ago

This seems to be fixed now (the two args solution at least works for me)

jasonlundien commented 1 year ago

@cmitjans-at-wiris

Are you still getting the error using the 3 args ?

 nuxtApp.vueApp.component("font-awesome-icon", FontAwesomeIcon, {})

I am not seeing the error in the console ?

And if you do not mind sharing... are you using the "Error Lens" to view the inline errors in VS Code or using something else (I am not seeing any inline errors via Error Lens either)?

jasonlundien commented 1 year ago

@cmitjans-at-wiris ---

Going to go ahead and close this issue. If you provide a reproducible repo we can re-open.