FortAwesome / vue-fontawesome

Font Awesome Vue component
https://fontawesome.com
MIT License
2.38k stars 132 forks source link

3.x Types Issue: FontAwesomeIconProps missing values #428

Closed brandon-mork closed 1 year ago

brandon-mork commented 1 year ago

Describe the bug Types in index.d.ts FontAwesomeIconProps do not match actual expected props in FontAwesomeIcon.js.

Expected behavior Exact match of supported props and associated types definition.

Reproduction Unintuitive breakage due to missing types, string "false" evaluates to true:

Functioning code to pass boolean false value instead of string, which consuming developer would know to use if types were present:

Additional context Issue introduced by: https://github.com/FortAwesome/vue-fontawesome/pull/366 PR merged under https://github.com/FortAwesome/vue-fontawesome/issues/415 fixed one piece of the issue, but left much of the issue remaining.

Exact diff of expected types

+ bounce?: boolean
+ shake?: boolean
+ beat?: boolean
+ fade?: boolean
+ beatFade?: boolean
+ flash?: boolean
+ spinPulse?: boolean
+ spinReverse?: boolean
jasonlundien commented 1 year ago

@brandon-mork ---

Oh my goodness, you are right, I missed them... somehow (I have no idea how).

I will get this PR submitted and merged as well. Thank you !!!

brandon-mork commented 1 year ago

You rock- thanks @jasonlundien!! :)

jasonlundien commented 1 year ago

@brandon-mork ---

PR merged. So I am going to go ahead and close this one now. Thanks again for your help.

Also, I am going to add you as a contributor unless you tell me other wise. Have a great one !!!