Closed jasonlundien closed 11 months ago
Prettier has taken over these files as well @robmadole. I left comments where I changed the code (6 total).
index.es.js
and index.js
were updated automatically with npm run dist
index.d.ts
, which is 1 of the 6 comments.@jasonlundien the changes look good. But the stuff prettier did is a little annoying. Were you surprised by them? I almost wonder if something is misconfigured in VSCode.
@robmadole ---
@jasonlundien the changes look good. But the stuff prettier did is a little annoying. Were you surprised by them? I almost wonder if something is misconfigured in VSCode.
I went back and adjusted my prettier settings to reflect those of Font Awesome. The prettier changes are now fewer than they were but you will still see some the changes --- for consistency. The exception is the index.es.js
file which prettier did quite a number on... this file was auto updated when I ran the npm run dist
.
I am fine with these prettier changes and being consistent going forward if you are ?!
This PR addresses this bug report: title property breaks snapshots#181
Currently we cannot add and set a title property without a random generated string being attached to the
aria-labelledby
and thetitle id
.This PR will allow us to set a
title
andtitleId
so that there would NOT be a random generated string if set, and snapshot tests will now pass.@robmadole --- can you review code for accuracy?