FortAwesome / vue-fontawesome

Font Awesome Vue component
https://fontawesome.com
MIT License
2.39k stars 132 forks source link

Vue 3x - Update for titleId and maskId prop #455

Closed jasonlundien closed 11 months ago

jasonlundien commented 1 year ago

This PR addresses this bug report: title property breaks snapshots#181

Currently we cannot add and set a title property without a random generated string being attached to the aria-labelledby and the title id.

image

This PR will allow us to set a title and titleId so that there would NOT be a random generated string if set, and snapshot tests will now pass.

image

@robmadole --- can you review code for accuracy?

jasonlundien commented 1 year ago

Prettier has taken over these files as well @robmadole. I left comments where I changed the code (6 total).

robmadole commented 1 year ago

@jasonlundien the changes look good. But the stuff prettier did is a little annoying. Were you surprised by them? I almost wonder if something is misconfigured in VSCode.

jasonlundien commented 1 year ago

@robmadole ---

@jasonlundien the changes look good. But the stuff prettier did is a little annoying. Were you surprised by them? I almost wonder if something is misconfigured in VSCode.

I went back and adjusted my prettier settings to reflect those of Font Awesome. The prettier changes are now fewer than they were but you will still see some the changes --- for consistency. The exception is the index.es.js file which prettier did quite a number on... this file was auto updated when I ran the npm run dist.

I am fine with these prettier changes and being consistent going forward if you are ?!