FortAwesome / vue-fontawesome

Font Awesome Vue component
https://fontawesome.com
MIT License
2.38k stars 134 forks source link

Update index.d.ts to add export declaration. #462

Closed shigeyf closed 1 month ago

shigeyf commented 1 year ago

This fix will resolve the problem (Issue #418) caused by ESlint.

The error message is:

error FontAwesomeIcon not found in '@fortawesome/vue-fontawesome' import/named

ThomasBerneHCSE commented 1 year ago

Any updates on this ? Why hasn't it been merged yet?

drusellers commented 7 months ago

Also interested in this

Kwaadpepper commented 6 months ago

I encountered this issue also.

nclemeur commented 5 months ago

Would it be possible to also export FontAwesomeIconProps as I was using it and now I have the error:

error TS2724: '"@fortawesome/vue-fontawesome"' has no exported member named 'FontAwesomeIconProps'. Did you mean 'FontAwesomeIcon'?
jasonlundien commented 1 month ago

Hey everyone,

I am not seeing the FontAwesomeIcon not found in '@fortawesome/vue-fontawesome' import/named error using nuxt (my test repo: https://github.com/jasonlundien/fa-nuxt3-ts )

Does anyone have a test repo they could share that is showing the FontAwesomeIcon not found in '@fortawesome/vue-fontawesome' import/named error ?

jasonlundien commented 1 month ago

I do not believe this is needed any longer. With the Release of 3.0.8, we are now exporting the following props in index.d.ts.

export { FontAwesomeIcon, FontAwesomeIconProps, FontAwesomeLayers, FontAwesomeLayersProps, FontAwesomeLayersText, FontAwesomeLayersTextProps }

If you think we still need something on the PR just let me know.

jasonlundien commented 1 month ago

I believe we have the exports fixed up now with the Release of 3.0.8; we are now exporting the following props in index.d.ts.

export { FontAwesomeIcon, FontAwesomeIconProps, FontAwesomeLayers, FontAwesomeLayersProps, FontAwesomeLayersText, FontAwesomeLayersTextProps }

Let us know if anything else pops up. Thank you, -jason