search

FortAwesome / wordpress-fontawesome

Font Awesome Official WordPress Plugin
Other
56 stars 19 forks source link

Set font-display rule to block to make Lighthouse happy #108

Closed oleksandrzaiats closed 3 years ago

oleksandrzaiats commented 3 years ago

Hi! It seems that the issue (https://github.com/FortAwesome/Font-Awesome/issues/16077 that seem to be fixed in the mail repo) still persists when using Font Awesome Wordpress plugin (https://wordpress.org/plugins/font-awesome/). I am using that plugin (with the latest version of font - 5.15.2) and I get Leverage the font-display CSS feature... in the report from Lighthouse. This warning displays fonts from urls like https://use.fontawesome.com/releases/v5.15.2/webfonts/fa-** as affected. I checked the code of that plugin and it seems like there is no font-display set. I did not find any issue tracking for that plugin so I decided to write here. Is it possible to fix that? Thanks!

mlwilkerson commented 3 years ago

closed by #110

mlwilkerson commented 3 years ago

@oleksandrzaiats this has been released in 4.0.0-rc22 (forgot to include it in the changelog!)

oleksandrzaiats commented 3 years ago

@mlwilkerson Thanks! I have updated the plugin and can confirm that the issue is solved now.