FortAwesome / wordpress-fontawesome

Font Awesome Official WordPress Plugin
Other
57 stars 19 forks source link

remove and document widget_text do_shortcode filter #131

Closed mlwilkerson closed 2 years ago

mlwilkerson commented 2 years ago

@frrrances what do you think of including this? It's technically a breaking change, though it seems pretty minor.

I discovered it when looking into how to capture that issue we noticed with shortcodes not being processed in the post excerpts. Seems like something should probably be the concern of a theme, instead of this plugin, since invoking do_shortcode would not only process our shortcode, but all registered shortcodes.

I realized that we were already doing something like that for widget_text (see the diffs). In other words, we were invoking the processing of all shortcodes for widget_text. I think that's a side effect that this plugin should not be causing.

It's possible that users will have come to rely on that side effect though, which is why it would be a breaking change. In the readme.txt I offered a one-liner that could be added to their theme to re-enable this if that's what they still want.

This also seems to confirm for me that, by analogy, when it comes to the excerpt text, it is the concern of the theme--and not this plugin--to determine whether shortcode processing should be enabled there.