FA WP plugin 4.1.0 with WP 5.9 crash on update

[TravelingTartar]

Upon install of 4.1.0, on a WP 5.9 site, the site blocked. Went in via recovery mode, deactivated and reactivated the plugin and it worked. Repeated and still had same problem. So now works, but only because I went in via recovery mode. Hope this helps.

[tagliala]

Hi!

Thanks for being part of the Font Awesome Community.

The proper repository for this issue should be https://github.com/FortAwesome/wordpress-fontawesome, but I cannot transfer this issue

@mlwilkerson could you please take a look here and transfer the issue if you think it is the case?

[TravelingTartar]

Hi. Sorry about that. I just followed the bug report link on the FA website.

On 1/27/22, at 07:43 (EST), Geremia Taglialatela @.***> wrote:

Hi!

Thanks for being part of the Font Awesome Community.

The proper repository for this issue should be https://github.com/FortAwesome/wordpress-fontawesome https://github.com/FortAwesome/wordpress-fontawesome, but I cannot transfer this issue

@mlwilkerson https://github.com/mlwilkerson could you please take a look here and transfer the issue if you think it is the case?

— Reply to this email directly, view it on GitHub https://github.com/FortAwesome/Font-Awesome/issues/18612#issuecomment-1023167534, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADIX5PLWJN4NSJ76U7MMYP3UYE4VNANCNFSM5M5T6GZQ. You are receiving this because you authored the thread.

[tagliala]

Hi, no problem 👍🏼

maybe we can improve that section in the future

[mlwilkerson]

Hi @TravelingTartar. Thanks for the report. I suspect that this occurred because the plugin tries to refresh metadata about available releases for upgrades where the options database schema changes (as was the case in this release). And it may be that if many WordPress sites simultaneously do that upgrade, it puts an excessive load on the API server. We've introduced a couple of layers of caching to mitigate against that. But I wonder if there's a corner case I hadn't yet considered.

So I'm considering what corner case may be there, and also what would be a better way to handle this kind of upgrade.

It would help to know how you have the plugin configured. Specifically: have you added an API Token? Related (but separate), are you using the plugin with a Kit?

[mlwilkerson]

Note to Self:

Initially, it seems mostly likely that the plugin upgrade triggered an excessive load on the API server, and blocking network requests to the server resulted in blocked page loads.

A possible solution is to avoid refreshing release metadata in try_upgrade(), unless necessary. And, thinking through various scenarios, it shouldn't be necessary, even when upgrading the data schema of the font-awesome or font-awesome-releases options schemas.

[mlwilkerson]

@TravelingTartar It might also help to know whether you see any other "registered" themes or plugins on the Troubleshoot tab in this plugin's settings page.

[TravelingTartar]

Hi. Nope, none, as per attached screenshot.

On 1/27/22, at 15:37 (EST), Mike Wilkerson @.***> wrote:

@TravelingTartar https://github.com/TravelingTartar It might also help to know whether you see any other "registered" themes or plugins on the Troubleshoot tab in this plugin's settings page.

— Reply to this email directly, view it on GitHub https://github.com/FortAwesome/wordpress-fontawesome/issues/159#issuecomment-1023618126, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADIX5PLV6HYHLAW7LXNGYLDUYGUHDANCNFSM5M6W522Q. You are receiving this because you were mentioned.

[mlwilkerson]

@TravelingTartar your screenshot didn't come through with that attachment. But that's OK. I can work without it.

[mlwilkerson]

I just release version 4.1.1 of the plugin that has simplified upgrade logic. In particular, it makes no network requests to refresh metadata from the API server upon upgrade. I think this is most likely the issue.

NOTE: I've not seen any problems with upgrading to 4.1.0 under WP 5.9. So I don't think there's an issue with WP 5.9 compatibility. If something else comes up for someone else, of course, we'll get a new investigation going on a new issue.

Thanks again for the report.