FortAwesome / wordpress-fontawesome

Font Awesome Official WordPress Plugin
Other
57 stars 19 forks source link

Using ${var} in strings is deprecated #201

Closed lifeinthegrid closed 12 months ago

lifeinthegrid commented 1 year ago

Hi Guys,

Thanks for the plugin! Getting allot of deprecation messages in PHP 8 with older string variable lookups.

Example of one of the messages.

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in \wp-content\plugins\font-awesome\includes\class-fontawesome.php on line 1945

Should be a super simple fix just switch it from ${var} to {$var}

Thanks much!

mlwilkerson commented 1 year ago

Thanks for the report!

masteradhoc commented 1 year ago

@mlwilkerson can you check my PR? :) would be great to get a new version soon

mlwilkerson commented 11 months ago

@masteradhoc and @lifeinthegrid This fix was released just now in 4.4.0.

I also discovered and fixed several more of the same kind of deprecation warnings for php 8.2 in PR #205