search

FortAwesome / wordpress-fontawesome

Font Awesome Official WordPress Plugin
Other
57 stars 19 forks source link

Confused Error: Whoops! You found a corner case #43

Closed mlwilkerson closed 4 years ago

mlwilkerson commented 5 years ago

The error message being display as a wp admin notice is:

The Font Awesome plugin has experienced a fatal error : Whoops! You found a corner case here. Version 4 compatibility for our webfont method was not introduced until Font Awesome 5.1.0. Try using a newer version, disabling version 4 compatibility, or switch your method to SVG.

To reproduce:

  1. delete the font-awesome options key from the db using wp option delete font-awesome
  2. re-load the plugin's admin settings page

This is being thrown from FontAwesome_Release_Provider::get_resource_collection

Need to improve the error handling here.

mlwilkerson commented 5 years ago

Probably we need to fix FontAwesome::options() to ensure that it returns a default set of options if the options key in the db is empty.