search

FortAwesome / wordpress-fontawesome

Font Awesome Official WordPress Plugin
Other
56 stars 19 forks source link

Pseudo-Elements Error #82

Closed hirenshah closed 3 years ago

hirenshah commented 4 years ago

Just noticed that when you are on the Font Awesome Settings page, under the section labelled Technology, if you do the following: 1) Select SVG 2) Make sure "Enable CSS Pseudo-elements with SVG" is unticked 3) Select Web Font (do all this without Saving Changes) 4) Save Changes

It results in the following error being displayed: Pseudo-elements cannot be disabled with webfont technology.

Annotation 2020-05-18 184046

Looks like your form validation isn't quite right. Everything appears to save fine though.

If you repeat what I mentioned above, but add an extra step, you don't see that validation error: 1) Select SVG 2) Make sure "Enable CSS Pseudo-elements with SVG" is unticked 3) Save Changes <-- extra step 4) Select Web Font 5) Save Changes

mlwilkerson commented 4 years ago

@hirenshah good catch. I think I know what's going on here. Should be an easy fix.

hirenshah commented 4 years ago

@mlwilkerson I can't take any credit for spotting this... it was literally a case of "my finger slipped" lol.

I don't think it is a big deal as it appears to only be a cosmetic issue :)