rouson
commented
8 years ago I agree with the idea of removing them. One of the great things about modern Fortran is that type finalization is rarely needed. Let's let the language shine. :)
Also, an extra procedure invocation is extra compute cycles. And I haven't looked at the code, but in the instance that the deal location fails, it's an additional place for the code to fail.
On a related note, if you'd like to build a newer version of GCC from source in your own user space without admin privileges, the OpenCoarrays installer will do it for you automatically and you'll then be able to write parallel coarray code as a bonus.
Sent from my iPhone
On Apr 15, 2016, at 7:15 AM, Chris MacMackin notifications@github.com wrote:
I notice that all of the finalization subroutines in the integrator types are unnecessary. They just set constants to zero or deallocate allocatables. While having an unnecessary finalization subroutine isn't a bit problem in and of itself, the version of gfortran (4.8.4) on the Ubuntu computer in my office does't support finalization and therefore won't compile. Ideally I would just install gfortran5 from the PPA, but the university doesn't trust us mere scientists with administrative rights.
In any case, I've commented out the finalization bindings as a workaround, but given that they aren't necessary and impede compiler support, I would suggest that they shouldn't be present at all. At the very least it would be good if you could add some preprocessor flags around them.
— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub
szaghi
I notice that all of the finalization subroutines in the integrator types are unnecessary. They just set constants to zero or deallocate allocatables. While having an unnecessary finalization subroutine isn't a bit problem in and of itself, the version of gfortran (4.8.4) on the Ubuntu computer in my office does't support finalization and therefore won't compile. Ideally I would just install gfortran5 from the PPA, but the university doesn't trust us mere scientists with administrative rights.
In any case, I've commented out the finalization bindings as a workaround, but given that they aren't necessary and impede compiler support, I would suggest that they shouldn't be present at all. At the very least it would be good if you could add some preprocessor flags around them.