search

Fortran-FOSS-Programmers / FoXy

Fortran XML parser for poor people
30 stars 13 forks source link

Suggested fix for compile error using Intel-2017.1.143 on Windows #5

Closed jeblohe closed 8 years ago

jeblohe commented 8 years ago

The Intel Fortran compiler 2017.1.143 on windows does not accept line 328 and 347 in foxy_xml_tag.f90. I think the compiler is correct on this issue. By definition function results behave like dummy arguments with intent(out). They are undefined when the function initiate. Hence they can not first appear on the right hand side of assignments. (Reference is made to page 78 of "Modern Fortran Explained" by Metcalf, Reid and Cohen) If the intention with these functions is to update whatever object is associated with _tag the functions must be turned into subroutines where _tag has intent(inout).

Using this suggested fix I can run the examples in VTKFortran and display the files in Paraview :-)

codecov-io commented 8 years ago

Current coverage is 87.33% (diff: 100%)

Merging #5 into master will not change coverage

@@             master         #5   diff @@
==========================================
  Files            12         12          
  Lines           758        758          
  Methods          61         61          
  Messages          0          0          
  Branches        106        106          
==========================================
  Hits            662        662          
  Misses           96         96          
  Partials          0          0

Powered by Codecov. Last update 59c0524...433b48c

szaghi commented 8 years ago

AAAARRRRRGGG.... this was one of my typo, my bad cut/paste!

@jeblohe Thank you very very very much for finding them, your help is very appreciated!