Fortran-FOSS-Programmers / ford

Automatically generates FORtran Documentation from comments within the code.
https://forddocs.readthedocs.io
GNU General Public License v3.0
407 stars 133 forks source link

fix internal procedure's calls not showing up in call graphs #514

Closed JosephWood2001 closed 1 year ago

JosephWood2001 commented 1 year ago

procedures that are internal to a procedure will now show their calls in call graphs.

ZedThree commented 1 year ago

Does this obey the proc_internals setting?

JosephWood2001 commented 1 year ago

Whoops, I didn't try this setting when doing my first commit.

looking into it, when proc_internals was off, the internal calls wouldn't show up in the call graphs 👍 , but the calls made by the internal calls wouldn't show up for the parent of the internal calls either 👎 (both before and after my first commit).

This commit fixes that issue by skipping over internal nodes that aren't 'visible'

ZedThree commented 1 year ago

Thanks @JosephWood2001 ! Please could you add a test or two for this?

JosephWood2001 commented 1 year ago

👍 , I've also moved where/how the internal proc calls are added to the all calls graph to a more appropriate spot.

ZedThree commented 1 year ago

Lovely, thanks!