Fortran-FOSS-Programmers / ford

Automatically generates FORtran Documentation from comments within the code.
https://forddocs.readthedocs.io
GNU General Public License v3.0
402 stars 131 forks source link

Bug in logic to skip big or incomplete graphs #627

Closed mscfd closed 5 months ago

mscfd commented 5 months ago

The condition in the if line in

        # Do not render overly large graphs.
        if len(self.added) > self.max_nodes and self.warn:
            warn(
                f"Not showing graph {self.ident} as it would exceed the maximal number of {self.max_nodes} nodes"
            )
            return ""

in graphs.py (line ca. 900) has been mangled in commit b497ad8a5dbe248a04b7934ac52bae10e1c7738f.

Independently of self.warn, if the first condition holds, then return an empty string.

There is another such test below this code block.

ZedThree commented 5 months ago

Thanks for catching this @mscfd!