FortunaSS13 / Fortuna

Former repository for the Fortuna 13 server
GNU Affero General Public License v3.0
11 stars 61 forks source link

Powders #476

Closed Pebblesthe2nd closed 2 years ago

Pebblesthe2nd commented 2 years ago

About The Pull Request

(Trying to do some atomizing so this is a sub branch of the other drug PR, so it counts the files changed there in this one as well.)

Problem: Healing Powder and Poultice have become all but obsolete due to linear effect to Bitter drink. This makes the choice illusory, there is only one viable way, and thats bad.

Solution: Healing powder buffed in healing (not as good as poultice but closer) and also now has a small dose of stimulants (stun resist and tiny speed boost) and antitox. Cave fungus used in the recipe cause Xander is overused, fungus underutilized, fits with antitox.

Problem: Legion is still limited in fun gimmicks. More culture specific stuff needed. Solution: Adds two stimulant powders for testing. Red powder: melee boost with stimulant. White powder: nerfed med-x. Both made with limited resources instead of just farm spammable ones. Powder now has yet another use. All Legion noncombat can make them.

Various stuff connected to this: Poultice yeeted. Very much obsolete at this point. Replaced with powder or bitter as appropriate. Berserker powder stuff: The associated stuff was commented out 5 months ago for a rework. Not gonna happen. Keeps the actual reagent code naturally, commented out detritus goes. Geckohide duplicate fixed Turbo sprite touched up 5 box of powders craftable, sprited Smelling salt icons improved (adding a dash of perspective, shading, reflection, size adjusted a little) Nerfed stimulant speedboost from 0.5 to 0.1.

Why It's Good For The Game

Rock paper scissor with at least two choices is more fun than linear with only one. Powder might actually be made with the changes, even if its still worse than bitter in pure healing.

For the legion stims, will probably need some tweaking to get just right, but needs some players to abuse the heck out of it to see if it holds up. Its a bit of a experiment, and can be easily adjusted. Legion needs some loving.

Pre-Merge Checklist

Changelog

:cl: add: Red & White powder del: Poultice gone tweak: Healing powder improved /:cl:

Kneesox44 commented 2 years ago

Healing Powder is canonically Broc + Xandar, so changing the recipe away from that might be an issue.

Sad to see Poultice go, because I frequently use it as both Legionary, Tribal and Khan in game, but I can understand that most people don't see the merit of it compared specifically to bitter drink.

AdamElTablawy commented 2 years ago

Right, no, absolutely not.

One, we're not bringing back legion med-x. We're also not bringing back slowdown negation of any kind or speedboosts. All of that goes.

We're not boosting healing powder's healing properties.

We're not removing healing poultice.

On top of that, this PR is very bulky and unatomized. You've made med-x into a hypospray rather than a syringe, you've changed the uplink pathing for some reason to med-x instead of stimulants, you've changed the speedboost added by stimulants from -0.5 to -0.1 rather than making another large subtype.

Firstly, separate the legion redpowder into a different PR. And as for legion med-x, that's a hard no-they don't get a slowdown negator. Especially not an easily craftable one.

Secondly, just readd poultice keep powder as it is. Don't make powder better than improvised stimpaks, seriously. -3.5 is better than they are.

Just give bitter drink a different role rather than treating brute/burn. Make it a toxin and stamina healer or something. Have it work as a coagulant or such to treat bleeding wounds. Idk.

Legion mains' feedback on this so far as written has been negative.

Pebblesthe2nd commented 2 years ago

Had a bit of computer breakdown, got a old laptop now at least. As for relevant comments

Poultice is just powder+, making it semi-useful, even if not time-efficient to produce. Letting powder fill this slot instead of being obsolete for no good reason makes sense. A bit of rock-paper-scissor balance = good, Making powder actually a bit useful = good.

When the premium version becomes the new standard baseplate you fucked up the balance, simple as. The current version of tribal meds is the one with the least actual depth in practice, at least since poultice was introduced.

As for Med-x,, it was still in existence and used a whole bunch a week or two ago, so unless it changed very recently speed debuff negators are very much a thing. If it's been reworked just now, then no complaints from me, just a bit surprised by the timing. White & Red powders are obviously concepts that needs live fieldtesting either way, thats the whole point.

To be frank I think Legion is pretty close to rock bottom and needs some positive additions,

AdamElTablawy commented 2 years ago

Had a bit of computer breakdown, got a old laptop now at least. As for relevant comments

Poultice is just powder+, making it semi-useful, even if not time-efficient to produce. Letting powder fill this slot instead of being obsolete for no good reason makes sense. A bit of rock-paper-scissor balance = good, Making powder actually a bit useful = good.

When the premium version becomes the new standard baseplate you fucked up the balance, simple as. The current version of tribal meds is the one with the least actual depth in practice, at least since poultice was introduced.

As for Med-x,, it was still in existence and used a whole bunch a week or two ago, so unless it changed very recently speed debuff negators are very much a thing. If it's been reworked just now, then no complaints from me, just a bit surprised by the timing. White & Red powders are obviously concepts that needs live fieldtesting either way, thats the whole point.

To be frank I think Legion is pretty close to rock bottom and needs some positive additions,

They are the strongest faction in the game at the moment. The only thing right now is that stims are slightly bugged and i'm fixing that.

github-actions[bot] commented 2 years ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself