FortunaSS13 / Fortuna

Former repository for the Fortuna 13 server
GNU Affero General Public License v3.0
11 stars 61 forks source link

Ambush Tactics #488

Closed Tron-117 closed 2 years ago

Tron-117 commented 2 years ago

Updates how hostile mobs work, by adding a var which determines if it's peaceful or not, and also adding the ability to trigger certain things with the mob via voice commands.

About The Pull Request

A feature that was really, really wanted by people who do events, these new vars allow you to command mobs like never before. I'd like to think these additions are just a good foundation, as more command phrase vars can easily be added. Below is a video demonstrating three of the four commands.

https://streamable.com/4wenqh

This is possible with the peaceful variable, which makes mobs become friendly at the (proverbial) flip of a switch. Peaceful mobs become hostile if attacked, of course. However if they are hostile, that does not mean they'll attack just anyone, they are still bound to their faction vars.

Now, the types of phrases we can use:

  1. Attack Phrase - Mobs become hostile once this phrase is said
  2. Peace Phrase - Mobs become peaceful once this phrase is said (If they are attacked they WILL become hostile though)
  3. Reveal Phrase - Mobs uncamouflage themselves (if they were invisble before) once this phrase is said. Perfect for ambushes.
  4. Hide Phrase - Mobs camouflage themselves (to a set visibility) once this phrase is said.

It must be noted that the exact phrase must be uttered for the commands to work.

Why It's Good For The Game

Helps with events, and opens up the possibility for a lot of stuff.

Pre-Merge Checklist

Changelog

:cl: add: Added peaceful variable to hostile simple mobs add: Added voice commands to hostile simple mobs /:cl:

github-actions[bot] commented 2 years ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself