FortuneN / FineCodeCoverage

Visualize unit test code coverage easily for free in Visual Studio Community Edition (and other editions too)
https://marketplace.visualstudio.com/items?itemName=FortuneNgwenya.FineCodeCoverage
Other
526 stars 40 forks source link

Enable installation on Visual Studio 2022 for ARM64 #439

Closed craigktreasure closed 3 months ago

craigktreasure commented 3 months ago

This change adds support for the arm64 platform architecture to the VS 2022 extension by updating the Microsoft.VSSDK.BuildTools package to the latest version (17.11.414) and adding a new entry for the arm64 ProductArchitecture.

Built and tested on my Surface Pro 11 running VS 17.10.4 for ARM 64-bit. As best I can tell, everything seems to work.

I believe this PR addresses https://github.com/FortuneN/FineCodeCoverage/issues/436.

It's worth mentioning that the number of warnings produced during the build (at least from my local build) went from 2 to 19. The new warnings are likely due to updated analyzers from the package upgrade. Here are the new warnings:

The new warnings include:

tonyhallett commented 3 months ago

So you did not encounter any of the problems from https://github.com/FortuneN/FineCodeCoverage/issues/352 - Excss exception / bad image format exception ? What version of vs are using to build and run the extension ?

craigktreasure commented 3 months ago

I'm using VS 17.10.4 on arm64 to build and run it.

I am not experiencing the issue mentioned there. Not sure how to explain that.

Would be great to get a second opinion.

craigktreasure commented 3 months ago

I wonder if @dpmurphy would mind giving my changes a try.

dpmurphy commented 3 months ago

Yes tomorrow

On Jul 21, 2024, at 9:24 PM, Craig Treasure @.***> wrote:



I wonder if @dpmurphyhttps://github.com/dpmurphy would mind giving my changes a try.

— Reply to this email directly, view it on GitHubhttps://github.com/FortuneN/FineCodeCoverage/pull/439#issuecomment-2241875389, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABEDFABZ3YJGRVVDN7F3TU3ZNRNLBAVCNFSM6AAAAABLGAC3NSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRHA3TKMZYHE. You are receiving this because you were mentioned.Message ID: @.***>

tonyhallett commented 3 months ago

@craigktreasure Please use the vsix from the marketplace and let me know if there are any issues. Thanks

dpmurphy commented 3 months ago

Yes vsix from marketplace works now arm64, mac based with VS2022 community edition.

Thanks so much.

From: Tony Hallett @.> Date: Monday, July 22, 2024 at 8:42 AM To: FortuneN/FineCodeCoverage @.> Cc: Daniel Murphy @.>, Mention @.> Subject: Re: [FortuneN/FineCodeCoverage] Enable installation on Visual Studio 2022 for ARM64 (PR #439)

@craigktreasurehttps://github.com/craigktreasure Please use the vsix from the marketplace and let me know if there are any issues. Thanks

— Reply to this email directly, view it on GitHubhttps://github.com/FortuneN/FineCodeCoverage/pull/439#issuecomment-2242863449, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABEDFAFUXSDOF4PCWBMCT4DZNT4Z5AVCNFSM6AAAAABLGAC3NSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBSHA3DGNBUHE. You are receiving this because you were mentioned.Message ID: @.***>

tonyhallett commented 3 months ago

@dpmurphy Sorry, I am confused with comment above and https://github.com/FortuneN/FineCodeCoverage/pull/440#issuecomment-2242923181

dpmurphy commented 3 months ago

When I built the vsix myself it failed to load the windows correctly. But the one I installed from the marketplace is working fine.

From: Tony Hallett @.> Date: Monday, July 22, 2024 at 9:31 AM To: FortuneN/FineCodeCoverage @.> Cc: Daniel Murphy @.>, Mention @.> Subject: Re: [FortuneN/FineCodeCoverage] Enable installation on Visual Studio 2022 for ARM64 (PR #439)

@dpmurphyhttps://github.com/dpmurphy Sorry, I am confused with comment above and #440 (comment)https://github.com/FortuneN/FineCodeCoverage/pull/440#issuecomment-2242923181

— Reply to this email directly, view it on GitHubhttps://github.com/FortuneN/FineCodeCoverage/pull/439#issuecomment-2242970962, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABEDFAFXAMEPUO673PWAZJ3ZNUCUJAVCNFSM6AAAAABLGAC3NSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBSHE3TAOJWGI. You are receiving this because you were mentioned.Message ID: @.***>

tonyhallett commented 3 months ago

@dpmurphy Ok at least it works from the marketplace.

The report UI will be changed at some point and Excss will be removed.