Can't install on VS 2022 Professional

DoctaJonez commented 3 months ago

Installed product versions

Visual Studio: [2022 Professional]
This extension: [example 1.1.223]

Description

Installation fails with VSIXInstaller.NoApplicableSKUsException: This extension is not installable on any currently installed products.

Steps to recreate

Attempt to install for VS2022 Professional

Current behavior

Fails to install

Expected behavior

Installs correctly

Side Notes

The manifest lists Community as the only supported edition of VS. This is supported by the failure install log:

01/08/2024 11:13:39 - Supported Products : 01/08/2024 11:13:39 - Microsoft.VisualStudio.Community 01/08/2024 11:13:39 - Version : [17.10,18.0) 01/08/2024 11:13:39 - ProductArchitecture : amd64 01/08/2024 11:13:39 - Microsoft.VisualStudio.Community 01/08/2024 11:13:39 - Version : [17.10,18.0) 01/08/2024 11:13:39 - ProductArchitecture : arm64

tonyhallett commented 3 months ago

It is installable in Visual Studio Professional. What version of Visual Studio do you have ? Where are you obtaining the vsix from ?

DoctaJonez commented 3 months ago

I'm using Visual Studio Professional 2022, version 17.8.7.

I've tried installers from the marketplace (https://marketplace.visualstudio.com/items?itemName=FortuneNgwenya.FineCodeCoverage2022), and I've also tried the releases section on github.

The logs of the installer say that the only supported version is the community version, this is also indicated in the manifest file in the github repo. I think this is probably in error, but I'm not an expert in extension development.

If you look at https://github.com/FortuneN/FineCodeCoverage/blob/master/FineCodeCoverage2022/source.extension.vsixmanifest you can see that Community is listed twice, but no other editions are listed.

<Installation>
        <InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[17.10,18.0)">
            <ProductArchitecture>amd64</ProductArchitecture>
        </InstallationTarget>
        <InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[17.10,18.0)">
            <ProductArchitecture>arm64</ProductArchitecture>
        </InstallationTarget>
    </Installation>

Edit: I've just noticed the requirement for version 17.10. I will try updating and see if it will work.

tonyhallett commented 3 months ago

The logs of the installer say that the only supported version is the community version

It does not state that. The supported products is Community and above.

tonyhallett commented 3 months ago

Updating to 17.10 will resolve the issue.

DoctaJonez commented 3 months ago

Thank you for explaining. Sorry for misunderstanding.

DoctaJonez commented 3 months ago

Updating to 17.10 has resolved it. I'm going to close this issue, thank you for your help.

tonyhallett commented 3 months ago

no problem

DerReparator commented 2 months ago

I had the same problem with Visual Studio version 17.9.2.

Unfortunately, I cannot easily update to 17.10.

My question is: Is the big version bump from 3 weeks ago (-> https://github.com/FortuneN/FineCodeCoverage/commit/5ccad9106b629cf85b534cc6eb072da4559f3f13) from 17.0 -> 17.10 really necessary?

Thank you for any information!

tonyhallett commented 2 months ago

@DerReparator The manifest matches the version of the Sdk package reference updated in the pull request. Is it really necessary? Not to the latest version but possibly a required version for Arm support.

DerReparator commented 2 months ago

Okay, thank you for the quick reply! I will use a slightly older version of FCC until I can upgrade to 17.10 and beyond 😀 Just wanted to make sure that the requirement was necessary.

tonyhallett commented 2 months ago

@DerReparator As I said, probably not necessarily. Fork the repo and build the vsix.

FortuneN / FineCodeCoverage