FortuneStreetModding / csmm-qt

Custom Street Map Manager cross-platform port
GNU General Public License v3.0
4 stars 0 forks source link

Implement more useful error messages #1

Closed Hubcapp closed 3 years ago

Hubcapp commented 3 years ago

Hi, thanks for the tool. Before its official release, I think you should consider improving your error messages.

A message like this does not offer the user any ability to diagnose their issue:
there was an error

I would recommend changing this function to return an int instead of a boolean, so that you are able to provide a more useful message. e.g. "Could not find frbFile1". https://github.com/FortuneStreetModding/csmm-qt/blob/8692b46bdb0486ac552a81a5f124c35314a39547/lib/patchprocess.cpp#L346