FortuneStreetModding / csmm-qt

Custom Street Map Manager cross-platform port
GNU General Public License v3.0
4 stars 0 forks source link

[Bug] Custom District Name patch supports longer names, but only partially #36

Open MysticMismagius opened 2 years ago

MysticMismagius commented 2 years ago

I tested out the new Custom District Name patch last night, replacing the districts in Peach's Castle with some world names from Super Mario 64. The gray bar shows the district perfectly. It looks great!

However, it falls apart in the stock menu, because the names are too long and they start spilling over into the next line.

The solution isn't as easy as just using an `` command to make a line break in the district names. That command doesn't work there, for starters:

And even if it did work while somehow not breaking the district name display on the gray bar, it would be a band-aid fix at best because districts that take up two lines in the stock menu fight with each other for space.

Widening the stock display won't really work either, since 4:3 mode exists and has very little blank space in the stock menu (especially if you have a very wide board, like this example):

The district roulette can be widened pretty easily, and the pop-up text boxes have plenty of space to spare even in 4:3 mode, so those aren't a problem at all.

However, the text in the stock menu is pretty much going to have to be squished if long names have any chance of being fully supported. This can either be done dynamically, the way Fortune Street Special squishes the text of long district names, or it can be a static squishing of all the district names in the stock menu.

ZaSpai commented 2 years ago

The issue also occurs in Individual Standings where there's even less horizontal real estate to work with.

itadaki_individual

(These district names all display on a single line in the stock menu.)

ZaSpai commented 2 years ago

As an update to the above, interestingly enough the NUMBERS in the left panel of Individual Standings auto squash when dealing with values >=100000G... (and also a little bit with 10000-99999G, but not quite as obvious)

itadaki_textsquash

So there's certainly something that allows dynamic text squashing, now's just the question of how to apply it to the text on the right...

MysticMismagius commented 2 years ago

The dynamic text squashing also occurs in the board select menu, with the title of boards:

Don't ask what that title is supposed to be, I have no idea.