FortySevenEffects / arduino_midi_library

MIDI for Arduino
MIT License
1.56k stars 252 forks source link

More SysEx issues. #225

Open BenZonneveld opened 3 years ago

BenZonneveld commented 3 years ago

Context

Board Info:

Describe your project and what you expect to happen:

My project needs to receive a maximum of 2100 bytes of sysex data.

Describe your problem (what does not work):

Changing the SysExMaxSize following instructions and using the MIDI_CREATE_CUSTOM_INSTANCE macro does not work. Also, the Settings need the midi BaudRate. The attached code works when bypassing the macro.

Steps to reproduce

struct MySettings : public midi::DefaultSettings { static const long BaudRate = 31250; static const unsigned SysExMaxSize = 2100; // Accept SysEx messages up to 1024 bytes long. static const bool UseRunningStatus = true; };

//MIDI_CREATE_CUSTOM_INSTANCE(HardwareSerial, Serial1, MIDI, MySettings); // This does NOT change the Sysex Settings !!! midi::SerialMIDI Serial1MIDI(Serial1); midi::MidiInterface<midi::SerialMIDI, MySettings> MIDI((midi::SerialMIDI&)Serial1MIDI);

lathoub commented 3 years ago

see #167