search

FortySevenEffects / arduino_midi_library

MIDI for Arduino
MIT License
1.56k stars 252 forks source link

Added missing MidiControlChangeNumber definitions #260

Closed muxa closed 2 years ago

muxa commented 2 years ago

To address https://github.com/FortySevenEffects/arduino_midi_library/issues/259

Based on definitions from https://www.recordingblogs.com/wiki/midi-controller-message

franky47 commented 2 years ago

There are some errors, you've got duplicate names in the enum: https://github.com/FortySevenEffects/arduino_midi_library/runs/4347255153?check_suite_focus=true

muxa commented 2 years ago

@franky47 Fixed

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 99.625% when pulling 9edd85f20771bb54885bacdbd70a1c04ae9c24d4 on muxa:more-defs into 1944aca891df74be1a989bafba5fe618e4d9bd91 on FortySevenEffects:master.

franky47 commented 2 years ago

Great, thanks! Could you add those new definitions to keywords.txt, so that they are syntax highlighted please ?

muxa commented 2 years ago

@franky47 keywords added

franky47 commented 2 years ago

Thank you!

muxa commented 2 years ago

@franky47 what's the process for getting the new version of the library out to PlatformIO?

franky47 commented 2 years ago

You should be able to use a GitHub link as your dependency to point to the master branch which includes your PR: https://docs.platformio.org/en/latest/core/userguide/lib/cmd_install.html#git

muxa commented 2 years ago

@franky47 cool, I'll use that for now. Are you able to tag the latest as 5.0.3 so I can reference a specific version?

Is there anything I can help with to publish a new version of the library to PlatformIO?

franky47 commented 2 years ago

I usually try to batch several features/bugfixes into a release, these days I don't have a lot of time to do some archeology over what happened in the last two years since the last release, but I agree that an update is in order. I'll keep you posted.

franky47 commented 2 years ago

You could use a direct commit hash as an immutable reference to your PR in master: https://github.com/FortySevenEffects/arduino_midi_library.git#8e9805fc926f3b116df4579ff0b0b72bc0c97ec7