search

ForumPostAssistant / FPA

The Forum Post Assistant (FPA) script has been developed to assist Joomla!® forum posters to be able to post relevant system, instance, PHP and troubleshooting information directly in to a pre-formatted forum post. This will save a few hours of posting back and forth, asking for, and explaining how to acquire useful information in order for other forum users to help troubleshoot a problem.
https://forumpostassistant.github.io/docs/
GNU General Public License v2.0
25 stars 15 forks source link

PHP Fatal Error on Joomla Live Check #105

Closed RussW closed 4 years ago

RussW commented 4 years ago

FPA receives a PHP Fatal Error when checking for the latest Joomla! release if "allow_url_fopen" is disabled.

Check for php _allow_urlfopen enabled before running the doJOOMLALIVE function

sozzled commented 4 years ago

Very good. I was going to suggest that we do something to highlight the state of allow_url_fopen() in the FPA report (both GUI and FPA) because this setting impacts the ability to use the Joomla! Update component. We know that there certain PHP settings (e.g. Max. POST size and Max. Upload Size) which, improperly or inadequately set, affect a website owner's ability to install extensions as well as update J!.

It may be an idea to use a "traffic light" system to indicate these settings (and possibly "score" things in the confidence measure)?

RussW commented 4 years ago

have added _"allow_urlfopen" to the "Confidence Rating" as well ( https://github.com/ForumPostAssistant/FPA/commit/8f42c078272793beb745a4983b74fe4c53fd01d9 )

frostmakk commented 4 years ago

Would it be nice to put in an else statement around line 4180 with a different colored box saying something like "Could not be tested", instead of the box just missing?

RussW commented 4 years ago

absolutely, just a simple info box stating remote urls disabled or simplexml not available unable to check etc... would certainly be more user-friendly than just not showing anything.

Do you have time? or want me to have a tinker?

frostmakk commented 4 years ago

Since I'm not a native English speaking person, my sentences are never short enough to fit into a small box. 😢

RussW commented 4 years ago

You do well enough young sir (plus, your english is far better than my 20 year old Norwegian), just updated to commit ( https://github.com/ForumPostAssistant/FPA/commit/23ee11196fe9fb18e280cca3808d1b862f41d308 ) now with a message if SimpleXML or allow_url_fopen not available.

If you are happy and wish to PR/Release, go for it, unless we wait a few more days to see if any other reports come in.

frostmakk commented 4 years ago

Just thinking... If $canDOLIVE is false, both boxes will be missing. Is this visually ok, or would you like to do something about that as well?

RussW commented 4 years ago

I was happy to just not show anything if canDOLIVE is false, the viewer knows no different at that point, so I didn't think we needed to tell them that we couldn't do something, but if you think we need to inform the user of the fact that we couldn't perform those tasks, go for it, I have no problem.

[edit] the confidence rating will be reduced if cURL and allow_url_fopen or not available and will be noted in the dropdown list.

frostmakk commented 4 years ago

It's ok for me. Just had to ask. I will issue a bug fix release later today.

RussW commented 4 years ago

@frostmakk thank you, much appreciated as always.

frostmakk commented 4 years ago

Issue fixed. New release issued. Closing.