search

ForumPostAssistant / FPA

The Forum Post Assistant (FPA) script has been developed to assist Joomla!® forum posters to be able to post relevant system, instance, PHP and troubleshooting information directly in to a pre-formatted forum post. This will save a few hours of posting back and forth, asking for, and explaining how to acquire useful information in order for other forum users to help troubleshoot a problem.
https://forumpostassistant.github.io/docs/
GNU General Public License v2.0
25 stars 15 forks source link

More, and then some #124

Closed frostmakk closed 1 year ago

frostmakk commented 1 year ago

Well, it's that time of year again. The snow is knee deep and I have retreated to my computer cave.

This PR is mostly about GUI changes:

CFPC

nooku

SUC

AFandN

This one will only show if you are running J3.10 and a MariaDB version below 10.1 MinMariaOnJ310

As always: Please test. Comments and suggestions are welcome.

mandville commented 1 year ago

Sounds amazing Where is the option to tell a ise4 5h3u are not worthy of running joomla

On Wed, 14 Dec 2022, 19:40 Sveinung Larsen, @.***> wrote:

Well, it's that time of year again. The snow is knee deep and I have retreated to my computer cave.

This PR is mostly about GUI changes:

[image: CFPC] https://user-images.githubusercontent.com/25645600/207688487-d293948f-8376-4b03-9530-24f3e125bfd4.JPG

-

Added 'fileinfo'(from vJ4), and 'gd', as required PHP extensions.

Changed the order of searching for the platform file to find the most recent. There have been cases where old leftover platform files have given false results like this:

[image: nooku] https://user-images.githubusercontent.com/25645600/207689158-ec14a5b7-a8fe-4426-ab9e-eec1b17a3fa3.JPG

  • Changed the definition of $phpenv['phpCGI'] Before this PR only phpAPI CGI or CGI-FAST counted as 'phpCGI'. I have included litespeed, fpm-fcgi and uwsgi. Feel free to protest @RussW https://github.com/RussW 😄

[image: SUC] https://user-images.githubusercontent.com/25645600/207690633-bf5e94d0-dfd4-4cf8-b8d2-5302732fa4ce.JPG

-

Added check for minimum MariaDB version.

Redacted the rest of the 'sensitive' information from the GUI when Privacy is enabled.

Added check for disabled update sites.

MariaDB returns one dbHOSTSTAT less than MySQL, so had to IF the last explode to get rid of errors.

Added a new section at the bottom of the GUI. 'Additional Findings & Notes' as a kind of crossover from Fishikawa. This is the place to elaborate over issues cryptically reported in the FPA, or to describe issues that dont fit in elsewhere. Currently issues reported in this section are: Disabled update sites. Wrong Session_handler 'none' on J4+. Elaboration on the multiple version files found issue. No tables in database. No tables in database with config prefix, but others exist. Note regarding J3 on PHP 8.1+ Note regarding J4 on PHP 8.2+ TODO: Update when J4 is patched. Notes regarding minimum MariaDB version and J4.

[image: AFandN] https://user-images.githubusercontent.com/25645600/207691370-3c96a261-7fd0-4f87-ae1a-7296bccc4e61.JPG

This one will only show if you are running J3.10 and a MariaDB version below 10.1 [image: MinMariaOnJ310] https://user-images.githubusercontent.com/25645600/207691903-fdc6acb9-215d-40d8-9493-aa1395ba4e1d.JPG

As always: Please test. Comments and suggestions are welcome.

You can view, comment on, or merge this pull request online at:

https://github.com/ForumPostAssistant/FPA/pull/124 Commit Summary

File Changes

(1 file https://github.com/ForumPostAssistant/FPA/pull/124/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/ForumPostAssistant/FPA/pull/124, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG2A6PRN7AD773CXBCNUQLWNIPDFANCNFSM6AAAAAAS63YYII . You are receiving this because you are subscribed to this thread.Message ID: @.***>

RussW commented 1 year ago

No complaints from me with the updates, as ever thank you for your time and diligence.

If we are adding all the current SAPI interfaces, do we also want to add 'phpdbg' and even the rarely used 'fuzzer' interfaces too?

I'll test it out over the coming weekend.

frostmakk commented 1 year ago

Please do. That's your domain. I'm totally lost when it comes to server setups.

@mandville Mr. Nice Guy probably wouldn't have approved that option. 🤣

frostmakk commented 1 year ago

I noticed that some servers reported a fake MariaDB version like this: 5.5.5-10.4.25-MariaDB-cll-lve-log This was messing with the compatibility checs, so I added a routine to strip off those 6 first characters. Any comments @RussW ?

RussW commented 1 year ago

The additional information displayed with MariaDB is only under certain circumstances such as when running under LVE Control with MySQL Governor (such as the default for CloudLinux Enterprise) it displays the LVE container manager version as a prefix to the MariaDB version, so it is fine to be stripped/removed from the output for clarity.

Well caught @frostmakk

frostmakk commented 1 year ago

Thanks for the insight. So it's a version number. That could be a problem. I hope there aren't too many out there. Will keep an eye on this, and re-think the filter if necessary.

frostmakk commented 1 year ago

v1.6.6 released.