search

ForumPostAssistant / FPA

The Forum Post Assistant (FPA) script has been developed to assist Joomla!® forum posters to be able to post relevant system, instance, PHP and troubleshooting information directly in to a pre-formatted forum post. This will save a few hours of posting back and forth, asking for, and explaining how to acquire useful information in order for other forum users to help troubleshoot a problem.
https://forumpostassistant.github.io/docs/
GNU General Public License v2.0
25 stars 15 forks source link

Php71 etc #26

Closed frostmakk closed 7 years ago

frostmakk commented 7 years ago

I have just started experimenting with PHP language, and when I noticed that this script fails with PHP 7.1 , I thought it could be a useful learning experience trying to fix it. My coding experience is limited to visual basic, so please check that I haven't opened Pandora's box with my changes.

Comments to changes at line number: 773 and 959: Dealing with the fact that libraries/platform.php have been missing from joomla distributions since 3.6.3

1131: Script does not take into account all the localhost installations with no dbPassword

1910 and 2400: Fails in PHP 7.1 On second thought... it would probably be better to just comment out these two lines ?

1938: Added protostar and isis to core templates.

2426: Added later versions. Probably not 100% correct parameters.

2825: Added the "delete script after use" notice to the finished page.

Second batch. Added check box to show/hide core extensions. Fixed the other check boxes so they behave as expected. Added color to the extensions in forum output. Core is blue, 3rdP orange.

Anybody home? Third batch. Added Extensions enabled (1) or not (0) to the forum post output.

mandville commented 7 years ago

yes, people are home, if github tells people something happening. good you are looking at resolving the (previously unknown) php 7. issue. perhaps also look at the version 3.6.5 notification failure

frostmakk commented 7 years ago

Not exactly sure what you refer to with "3.6.5 notification failure". Maybe what I have adressed above regarding line 773 and 959? This PR has a bit more than the 7.1 fix to it, so give it a run and if there is some more issues i'll gladly look into it.