ForumPostAssistant / FPA

The Forum Post Assistant (FPA) script has been developed to assist Joomla!® forum posters to be able to post relevant system, instance, PHP and troubleshooting information directly in to a pre-formatted forum post. This will save a few hours of posting back and forth, asking for, and explaining how to acquire useful information in order for other forum users to help troubleshoot a problem.
https://forumpostassistant.github.io/docs/
GNU General Public License v2.0
25 stars 15 forks source link

Consistent use of _RES vs. _FPA constants #80

Closed sozzled closed 4 years ago

sozzled commented 4 years ago

There are many places in the source code that define constant names as _RES_XXXXXX There are equally many places in the source that define constant names as _FPA_XXXXXX

In effect they are the same thing (unless there is a constant named, for example, _RES_FRED and _FPA_FRED, that would cause a run-time error or logic bomb if renamed the same).

Whether or not this single script is "standalone", a "package" in its own right, or part of a bigger package, I suggest renaming all locally-defined constants consistently to aid with future maintainability ... for those who come after us.

Suggest renaming all constants currently named as _RES_XXXXXX as _FPA_XXXXXX or, altenatively, rename all _FPA_XXXXXX constants as _RES_XXXXXX or (third neutral choice) rename all _RES and _FPA constants as _PKG.

mandville commented 4 years ago

i have no objections