search

ForwarD-NerN / AntiShadowPatch

Reintroduces bugs that Mojang has patched
MIT License
3 stars 2 forks source link

[Bug] CCE supression working too often #1

Closed Notoriousi closed 8 months ago

Notoriousi commented 1 year ago

CCE update suppression seems to apply whenever it shouldn't.

Recreate: Step 1: place comparator Step 2: Make comparator check a (white?) shulker Step 3: Its using CCE, try opening the shulker, the server would crash (even with NotSoShadowExtras's crash fix)

If you place the comparator after placing the shulker you'd crash as well.

Crashlog: crash-2023-11-23_13.16.10-server.txt

ForwarD-NerN commented 9 months ago

Hello, thanks for reporting the issue! I somehow missed the Github notification about it and only found out now. Looking at the crash report, you've caused a block update, not in a player phase. I don't think it's because of my mod, maybe it's another mod causing the issue or some random block update? If you can reproduce it only with the latest version of AntiShadowPatch enabled, please let me know.

Also, thanks for providing the crash report. I found another issue with the CCE suppressor in my mod. Fixed it in 1.0.6.

Notoriousi commented 8 months ago

I think this was caused by another mod, unsure what one. Unable to replicate this using only your mods installed. Closing because of a false report.