search

ForzaElixir / rollbax

Exception tracking and logging from Elixir to Rollbar
https://hexdocs.pm/rollbax
ISC License
243 stars 52 forks source link

Use proper time units #102

Closed wojtekmach closed 6 years ago

wojtekmach commented 6 years ago

Oops, we can't do that without requiring Elixir 1.4+, currently we require 1.3+. I'm gonna close it because it may not be good enough reason to bump the requirement but I'm happy to make the change in any case, let me know!

whatyouhide commented 6 years ago

@wojtekmach if you are up for it (it's boring), I'd definitely appreciate choosing the unit conditionally at compile time based on Elixir version and then unquoting it where needed :)

wojtekmach commented 6 years ago

@whatyouhide Done. Do you want me to set travis to test on 1.3 too? Right now it doesn't so I didn't touch tests :)

whatyouhide commented 6 years ago

Oh yeah that would be great, thanks @wojtekmach! 💟

wojtekmach commented 6 years ago

@whatyouhide turns out Jason requires 1.4 so maybe we should require it here after all?

whatyouhide commented 6 years ago

Thanks @wojtekmach! 💟

whatyouhide commented 6 years ago

Yes, please open another PR for requiring 1.4 if you want, otherwise I'll do it :)

adamkittelson commented 5 years ago

Hi there, just checking if there's any ETA on when a version with this code will be pushed to hex.pm? I've got a warning about the :seconds -> :second thing bubbling up to my app from rollbax that would be neat to take care of. Thanks! 😄

whatyouhide commented 5 years ago

Just released v0.10.0 :).

adamkittelson commented 5 years ago

Great thanks! :D