Allow to configure rollbax to contact api server via proxy

[GermanDZ]

Why?

Because some security hardened production environments require to contact the "outside" internet through a proxy and hackney (the erlang http client used by rollbax) doesn't read the usual env vars used to config a proxy.

How?

Adding an optional entry to Rollbar.config allowing the specification of an URL to be passed to hackney to force the use of a proxy.

Caveats

• The testing changes seems very complicated but are fast enough
• hackney will ignore the proxy option in case the value is nil, which simplify a lot passing & using the config.

Kudos to @amuino for guiding me to this solution

[GermanDZ]

ping @whatyouhide

[whatyouhide]

Hey @GermanDZ, thanks for the contribution! I like it but all the infrastructure for testing it seems like overkill considering that we're basically testing a hackney feature. I would either:

• not test proxying, again it's a hackney feature so it's supposed to work and I'm fine with not testing it
• testing it through Mox (by mocking the HTTP client) and asserting that the proxy option is passed

Thoughts?

[GermanDZ]

I cannot use Mox to mock :hackney, being it an Erlang module without a behaviour (ArgumentError) module :hackney is not a behaviour, please pass a behaviour to :for)

My options right now:

1) Keep the Proxy server for test (current solution) 2) Add an indirection, extracting :hackney from the Rollbax.Client and using something like http_client/0, then for production http_client/0 will return the :hackney module, but during test we can mock it to return an alternative. This also could lead to allow to use other http client via configuration (but not seems too desirable) 3) Remove the test for being only a simple config (but I don't code without test)

[whatyouhide]

1 is what I would really prefer to avoid. 2 is what I meant when I said we could use Mox. I personally would go with 3, but either 2 or 3 are okay for me.

[GermanDZ]

Working on 2 …

[GermanDZ]

Finally I went for 3, no so much tests. Anyway, I've added a simple test just to ensure nobody removes the config without breaking the feature.

Now only check the request are made to the URL configured as proxy not the api_endpoint.

[whatyouhide]

Thanks @GermanDZ 💟