ForzaElixir / rollbax

Exception tracking and logging from Elixir to Rollbar
https://hexdocs.pm/rollbax
ISC License
243 stars 52 forks source link

use a regex when checking stack traces #78

Closed craig-day closed 6 years ago

craig-day commented 6 years ago

The way a stack traces displays a method name seems to have changed between Elixir version 1.4 and 1.5. Method names that contain spaces will now be wrapped in quotes, but they were not in 1.4. This causes two tests to fail because they are expected quotes that don't exist in Elixir versions prior to 1.5. Using this regex, we make the quotes optional to support multiple elixir versions.

/cc @lexmag @whatyouhide

craig-day commented 6 years ago

/cc @lexmag @whatyouhide (I edited your names into the description but I don't think that triggers a notification)