Fix no notification permission issue

FossifyOrg / Calendar

A simple calendar with events, customizable widgets and no ads.

https://www.fossify.org

GNU General Public License v3.0

590 stars 48 forks source link

Fix no notification permission issue #221

Open austinoneil opened 2 months ago

austinoneil commented 2 months ago

What is it?

[x] Bugfix
[ ] Feature
[x] Codebase improvement

Description of the changes in your PR

Fix issue when user could not add an event/task when notification permission was not granted.
Refactored some logic, extracting reused code into a reusable function.

Before/After Screenshots/Screen Record

Before:
After:

Fixes the following issue(s)

Fixes #220

Acknowledgement

[x] I read the contribution guidelines.

Aga-C commented 2 months ago

It should ask for the permission at least on the first app startup. Most people won't think about turning manually the permission. Remember that this app isn't done only for technically advanced users.

austinoneil commented 2 months ago

@Aga-C Good idea. I added a check in the latest commit.