Open PattaFeuFeu opened 11 months ago
@naveensingh Please check this.
@PattaFeuFeu
Since we are still starting out, we are focusing more on bug fixes than rewriting/modernizing code. You are welcome to work on this and I don't want to demotivate you but know that this is going to involve a lot of time-consuming testing (manual and otherwise) to ensure everything works properly in different timezones because the PR won't get merged until it works properly. For common tz-related issues, you can refer to existing and closed issues on SMT and here.
Thanks.
@naveensingh Speaking of testing: I was quite astonished that there’s not a single unit test in this codebase. Is there a reason for that?
@PattaFeuFeu no reason at all. All the apps were developed by a single person with no unit tests and it just stayed that way.
Checklist
Is your feature request related to a problem? Please describe.
Calendar currently uses Joda-Time in most parts. Joda-Time has been more or less deprecated since Java8 and with it
java.time
came to be. It will no longer get any feature upgrades or active maintenance:Describe the solution you'd like
I would like to implement a solution based on
java.time
. Java 8 library such asjava.time
are officially only supported with API level 26, but it’s possible to use them in older API levels such as 23 used by this app by using core library desugaring. I’ve used that in the past and it worked well, so I’d like to propose that solution here.I would also like to replace all usages of
java.util.Calendar
,java.text.SimpleDateFormat
wherever possible—java.time
and its formatters can make sure that time zones across different centuries work, and that formatting is a breeze.Additional context
If it is okay, please assign me this issue and I’ll get to it.