FossifyOrg / Calendar

A simple calendar with events, customizable widgets and no ads.
https://www.fossify.org
GNU General Public License v3.0
660 stars 53 forks source link

Unreadable text on some UI elements when using dynamic theme #41

Open min7-i opened 8 months ago

min7-i commented 8 months ago

Checklist

Describe the bug The attendee suggestion list is hard to read when using the material you colors in a light theme. Additionally, in light themes without material you colors the suggestion list uses a black background with white text.

To Reproduce Steps to reproduce the behavior:

  1. Make sure the app has the permission to access contacts.
  2. Use the material you colors with Android set to light mode.
  3. Create a new CalDAV event.
  4. Go to the attendee field.
  5. Start typing the name of one of your contacts.
  6. The contact suggestion list is shown.

Expected behavior For light themes the suggestion list uses a light background with a font color that provides enough contrast. I'd suggest to simply use a white background and a black font.

Screenshots material you light light theme material you dark
calendar attendees dropdown_material you light (2) calendar attendees dropdown_light calendar attendees dropdown_material you dark (2)

Device info (please complete the following information):

Additional context N/A

schneidr commented 8 months ago

I was about to post the same issue for the widget settings ... is it related enough to be handled in this issue or do you want a separate one for it?

Sample screenshot:

Aga-C commented 8 months ago

@schneidr It's related, no need for a new issue.

min7-i commented 8 months ago

I was about to post the same issue for the widget settings ...

I guess for the event list widget the areas marked in red are affected: calendar widget event list_material you light theme_github

left part: dialog shown when tapping on the button "Within the next year" right part: second dialog shown when selecting the custom option from the first dialog

schneidr commented 8 months ago

I was about to post the same issue for the widget settings ...

I guess for the event list widget the areas marked in red are affected:

Correct for the screenshot on the left. The widget itself is working properly for me after setting useful colors.

SpaceFrrog commented 7 months ago

I have some related enhancements to the Dynamic Color Theme. I've noticed that the colors are much brighter than specified in the Material Design Guidelines. For example, the background color of the FAB is A1-400 in dark mode, but according to the Material Guidelines it should be A1-700. I think it would be more visually pleasing if the Material Design Guidelines were adhered to, also for all other components!

Guidelines: https://m3.material.io/components https://m3.material.io/theme-builder#/dynamic Calendar_Colors Color_Chips

SpaceFrrog commented 2 months ago

Hello there, I have another adjustment on the design. The icon for the notification is still the old one. Maybe you can change it to the new one, which looks more consistent. I also think it would look more modern, if the official Material3 components were used instead of the custom layout components, especially for the Textfields. Thanks for your amazing work and maybe you can look into this.

https://m3.material.io/components/text-fields/overview