FEAT: added Sorting dialog to the timer tab

FossifyOrg / Clock

Combination of a beautiful clock with widget, alarm, stopwatch & timer, no ads

https://www.fossify.org

GNU General Public License v3.0

233 stars 15 forks source link

FEAT: added Sorting dialog to the timer tab #67

Open ronniedroid opened 5 months ago

ronniedroid commented 5 months ago

What is it?

[ ] Bugfix
[x] Feature
[ ] Codebase improvement

Description of the changes in your PR

Added a dialog for sorting timers by creation time or timer duration
added config entries for timer sorting order
updated the menu accordingly
Update strings

Before/After Screenshots/Screen Record

Before:
After:

Fixes the following issue(s)

Fixes #7 but the sorting by timer duration is not set as the default option, to keep it the same as the alarms default.

Acknowledgement

[X] I read the contribution guidelines.

Aga-C commented 5 months ago

Compare your solution to what's already in Alarms, because it behaves a bit differently:

If you have many timers, that they don't fit on screen, sorting scrolls view to the bottom. It doesn't happen in Alarms.
There's an animation with timers moving around. In Alarms there's no animation.

ronniedroid commented 5 months ago

My PR did not add those, they were already there, I just added sorting.

Aga-C commented 5 months ago

But there was no sorting before, so no one could see this behavior. I know you've just added sorting, but while adding a new feature, we should make sure that it behaves the same as in other places.

ronniedroid commented 5 months ago

But there was no sorting before, so no one could see this behavior. I know you've just added sorting, but while adding a new feature, we should make sure that it behaves the same as in other places.

Should I add animation to the alarms or remove it from the timers?

Aga-C commented 5 months ago

Don't add animation and remove it from Timers. We don't have animations while sorting in other apps.

ronniedroid commented 5 months ago

@Aga-C I managed to remove the animation, but the auto scrolling I haven't figured out yet, I will try again later, but though I will say it here and maybe someone can share a tip or an idea.

ronniedroid commented 5 months ago

I move to MyRecyclerViewAdapter for the TimerAdapter to be consistent with the AlarmsAdapter, no visual changes, but now we have no animations and the list does not scroll to the bottom.