FossifyOrg / Contacts

Easy and quick contact management with no ads, handles groups and favorites too.
https://www.fossify.org
GNU General Public License v3.0
245 stars 23 forks source link

`\,` not interpreted as space, yet interpreted as space in NextCloud contacts. #134

Closed RokeJulianLockhart closed 1 month ago

RokeJulianLockhart commented 1 month ago

Checklist

Affected app version

https://f-droid.org/repo/org.fossify.contacts_2.apk (https://github.com/FossifyOrg/Contacts/releases/download/1.0.1/contacts-2-foss-release.apk)

Affected Android/Custom ROM version

Android version 13
Build FP5.TT4D.A.157.20240417

from https://fairphone-android-builds.ams3.digitaloceanspaces.com/FP5/A13/FP5-TT4D-factory.zip

Affected device model

cpe:/h:fairphone:fairphone_5

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

At https://wim.nl.tab.digital/apps/contacts/All%20contacts/ (which uses at most https://github.com/nextcloud/contacts/releases/tag/v5.0.1, but I don't know exactly which version)

N:;;;Word1\,Word2;

is both interpreted as a space in the modification state, and rendered as one in the preview state.

Expected behavior

\, should render as a space ( ).

Actual behavior

\, renders as a comma (,).

Screenshots/Screen recordings

image

Additional information

No response

Aga-C commented 1 month ago

Can you provide any source that rendering \, as space is a proper behavior, not a bug in NextCloud? According to vCard documentation, it should just display a comma (https://datatracker.ietf.org/doc/html/rfc6350#section-3.4) because backslash is just an escape character.

RokeJulianLockhart commented 1 month ago

https://github.com/FossifyOrg/Contacts/issues/134#issuecomment-2170398569

@Aga-C, I can't (I'm no vCard exper) but I know that NC exports prefixes with spaces as with the spaces replaced by \,, and then renders them correctly when imported. If you're certain that this is a bug, I'll report it as such up there instead - we need not cater for NC's bugs.

Aga-C commented 1 month ago

Maybe they have a reason why they're displaying this way, I don't know if they would treat it as a bug. NC doesn't need to follow vCard format specification. However, in general, whatever character is prepended by backslash, that character should be displayed, not something different.

RokeJulianLockhart commented 1 month ago

https://github.com/FossifyOrg/Contacts/issues/134#issuecomment-2170404460

@Aga-C, in my conversations with the developers, my experience is that they attempt to adhere to vCard as best they can. I expect that this is a bug, so I've reported it at https://github.com/nextcloud/contacts/issues/3985#issue-2355295714.