automatic backup doesn't work

bingoxo commented 3 months ago

Checklist

[X] I can reproduce the bug with the latest version given here.
[X] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
[X] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
[X] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected app version

1.0.1

Affected Android/Custom ROM version

Android 14

Affected device model

Pixel 6a

How did you install the app?

Google Play Store

Steps to reproduce the bug

enable automatic backup

Expected behavior

automatic backup to work

Actual behavior

nothing happens

Screenshots/Screen recordings

No response

Additional information

i also can't choose an existing folder and have to create new one

Aga-C commented 3 months ago

What's the path to that existing directory?
Do you have this problem with all existing directories?
By "doesn't work" you also mean, that even if you created a new directory, it also haven't created backups?
Do you have a stock Android 14 or a custom ROM?

bingoxo commented 3 months ago

1- Internal/Download/"whatever folder i already have"

2-yes

3-yes

4- custom rom/grapheneos

Switch123456789 commented 2 months ago

I noticed the same, I picked a folder in Android/media. btw, how is it supposed to work? Does it make backups on every change?

Fairphone 5 / iodeOS / Android 14 / f-droid / v1.1

Aga-C commented 2 months ago

@Switch123456789 It runs once a day.

jfsanchez commented 1 month ago

Same problem here. I've tried this feature in Graphene OS and in Stock ROM in Google Pixel phones and Lineage OS 20 (Android 13). This problem seems only present in Graphene OS (Android 14). Fossify contacts version: 1.0.1 from fdroid. Same problem present in Simple Mobile Tools Contact Pro from the Play Store.

The automatic backup feature won't let you select any folder except the "Internal" because Graphene OS will enforce the file permissions (NONE). In my opinion, the intent to access a folder/file should be made first and then use that same folder given by the user.

This app has no file access permissions and as such you can only see/browse the Internal Storage (in Graphene OS) and then the app will only let you select that same internal folder for permissions. Moreover, it will prevent you from using any character such as ../ or / as a workaround in the filename AND will prevent you from manually editing the folder.

I don't understand why this is implemented in two steps: First you select the folder, then you give permissions by selecting the same folder in an intent and you can't change that folder. I asume is something related to older android versions, however you could just update with the folder you are offered by the system/user in the second step.

I propose two different solutions (I am no android developer, so I could be wrong):

1) Just use the file intent in a single step (if it has no drawbacks with older android versions that you want to support). 2) Let the app update the folder to save the file if the users selects another one when grating permissions. As an option you could show a warning.

Affected versions so far:

Fairphone 5 / iodeOS / Android 14 / f-droid / v1.1 (reported by: @Switch123456789)
Graphene OS / Android 14 / f-droid/ v1.0.1 and Play Store (also affect SMT Contacts Pro from Play Store). All versions since it seems a problem with a common lib (more information on next comment).

jfsanchez commented 1 month ago

I've been doing some research and I think the problem is in the common library, so it may affect the rest of the products. It seems that it calls a dialog implemented in a common lib for directory/file selection. As I've said, I am no expert in android and just was looking around. I would recommend having a look at it since it could also solve other problems.

Aga-C commented 2 weeks ago

Closing in favor of general bug report for all apps: https://github.com/FossifyOrg/General-Discussion/issues/211.

FossifyOrg / Contacts