search

FossifyOrg / Contacts

Easy and quick contact management with no ads, handles groups and favorites too.
https://www.fossify.org
GNU General Public License v3.0
284 stars 24 forks source link

Automatically exported .VCF can't be imported #31

Closed hetszunyukapanyanyimonyok closed 7 months ago

hetszunyukapanyanyimonyok commented 7 months ago

Checklist

Describe the bug Trying to import one of the daily automatically backed up .vcf file. It fails every time. I have tried other days backup, does not help. If I export manually, that works as normal import. (But that is not efficient enough)

To Reproduce Steps to reproduce the behavior:

  1. Import automatically exported .vcf file.
  2. Import failes.

Expected behavior To able to import, automatically exported .vcf files.

Device info (please complete the following information):

Additional context So i have analyzed the manually and the automatically exported .vcf files. Their data structures are Totally different. Because the manual works I did not touch it. Than I tried to clean/the automatic backed up one/ by allowing only 1 contact (Without extra infos for example: address; email etc.) and that failed too so based on this the automatically exported files must be broken by default.

Aga-C commented 7 months ago

Can you send an example of a non-working VCF file (anonymized)?

hetszunyukapanyanyimonyok commented 7 months ago

@Aga-C Hi! I have uploaded it in tresorit because GitHub does not support this file format if you need it I can email it or any solution that you have.

https://web.tresorit.com/l/JVxKp#_tBTZOJv6oTr0PAapeHLhw

Aga-C commented 7 months ago

Thanks! It looks that you got JSON exported instead of VCF. It surely needs to be fixed.

naveensingh commented 7 months ago

The feature was originally added at https://github.com/SimpleMobileTools/Simple-Contacts/pull/998 and https://github.com/SimpleMobileTools/Simple-Commons/pull/1739 but I have no idea why the contacts were exported in JSON.

@Merkost Do you remember why it was done that way or was it just a mistake? Sorry for the ping :)

Merkost commented 7 months ago

The feature was originally added at https://github.com/SimpleMobileTools/Simple-Contacts/pull/998 and https://github.com/SimpleMobileTools/Simple-Commons/pull/1739 but I have no idea why the contacts were exported in JSON.

@Merkost Do you remember why it was done that way or was it just a mistake? Sorry for the ping :)

Hi there, Json is used for app backups. It's standardized within all Simple apps. Vcf's are used for basic contract exports. The vcf format doesn't support the app's custom fields, that's why the backup is in this format.

hetszunyukapanyanyimonyok commented 7 months ago

@Merkost Hi, sorry my two cents question: Than why the manual export is in simple .vcf format and works when imported? (with hidden fields too)

Merkost commented 7 months ago

@Merkost Hi, sorry my two cents question: Than why the manual export is in simple .vcf format and works when imported? (with hidden fields too)

It will work, as the hidden fields are not custom ones

HarriBuh commented 7 months ago

Yes, this one here is an old bug from SimpleTools. I remember several opened issue threads about it (including mine) and it hasn't been tackled ever since.

naveensingh commented 7 months ago

Since VCF is a well-known file format, it makes sense for automatic backup exports to be in that format.

abdo2048 commented 7 months ago

Hi, I wanted to open new issue but maybe I could mention my problem here and I will open new issue if you need me to do so. As I understand, Automatic Backup Feature should backup the contacts (whether in vcf or json format as in this discussion) when a new contact is added, right? But the Automatic Backup Feature doesn't work with me at all! No files exported (vcf or json).

What I tried but the automatic backup didn't do anything:

  1. Adding new contact using Fossify Contacts app to my Samsung email.
  2. Adding new contact using Fossify Contacts app to my phone storage (which is not visible to other apps)
  3. Adding new contact using Samsung Contacts app to my Samsung email.
  4. Changed the path/folder of backup.

Device info OS: Android 14 (Samsung - One UI v6.0) App version: 1.0.1

Aga-C commented 7 months ago

@abdo2048 Automatic backup runs once a day.

abdo2048 commented 7 months ago

@Aga-C Sorry, I didn't know that. I think it would be better to show this piece of info in the app, I mean a phrase should be written in Settings under BACKUPS section that indicates the backup happens one time each day. And I believe adding the flexibility of choosing when to backup (Scheduling backups) would be great too. Thank you so much.

franco-bez commented 2 months ago

Since VCF is a well-known file format, it makes sense for automatic backup exports to be in that format.

aggreed.

what make me wonder is that the "fix" was implemented in January, but the bug is still there in July.