Add option to edit structured addresses (new)

FossifyOrg / Contacts

Easy and quick contact management with no ads, handles groups and favorites too.

https://www.fossify.org

GNU General Public License v3.0

269 stars 23 forks source link

Add option to edit structured addresses (new) #57

Open stephanritscher opened 6 months ago

stephanritscher commented 6 months ago

What is it?

[ ] Bugfix
[x] Feature
[ ] Codebase improvement

Description of the changes in your PR

Introduce option to edit structured addresses as requested.
Based on this fork,
In the current state, the PR changes the dependency to my fork of Commons. This needs to be revisited before merging.

Before/After Screenshots/Screen Record

Before:
After:

Fixes the following issue(s)

Fixes #30.

Relies on the following changes

https://github.com/FossifyOrg/Commons/pull/32

Acknowledgement

[x] I read the contribution guidelines.

raycadle commented 6 months ago

This PR would make Fossify Contacts so much better. I've stayed with Simple Contacts Pro SE, as the structured address feature allows my contacts to integrate very well into my Nextcloud instance.

stephanritscher commented 6 months ago

@naveensingh What do you think about the feature respectively pull request?

naveensingh commented 6 months ago

@stephanritscher Sounds like a good idea but I'm curious, why wasn't this merged in the original Simple Contacts?

Note: I'm yet to review this or any other PR.

stephanritscher commented 6 months ago

Tibbi didn't like having additional options and didn't regard this as important feature.

alensiljak commented 5 months ago

Note: I'm yet to review this or any other PR.

This is implemented and works well in Simple Contacts Pro SE. Probably the sooner it is merged, the less issues there would be in the process. It is a great feature. I've been fixing addresses for the last 30 years and if it is only because someone didn't find it important enough than it is just plain sad. Please!