Filter does not filter favorites view

akki42 commented 9 months ago

Checklist

[ ] I can reproduce the bug with the latest version given here.
[X] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
[X] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
[X] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected app version

v1.0.0 (latest from Play Store)

Affected Android/Custom ROM version

LineageOS 20

Affected device model

Pixel 4a 5G, Samsung Tab S5e

How did you install the app?

Google Play Store

Steps to reproduce the bug

Mark contact from source X (e.g. local or nextcloud / davx5 account) as favorite
Filter (uncheck checkbox) source X
Switch to Favorites view

Expected behavior

Contact from filtered (unselected) source is not shown

Actual behavior

Contact is shown despite source being filtered (unselected)

Screenshots/Screen recordings

No response

Additional information

No response

Aga-C commented 9 months ago

Can you turn off merging duplicates in Settings and check if the favorite contact is, in fact, from the filtered out source?

akki42 commented 9 months ago

I already checked that. (In fact, I realized the current behavior when I was shown duplicate favorites even though only one source was active / selected.)

You can also try it out with a newly created 'test' contact. It will be shown (if marked as favorite) even when its source / storage is filtered / unselected.

Aga-C commented 9 months ago

It may be OS specific, I couldn't reproduce it on my stock Android 13 (OnePlus 8 Pro), Android 10 (Xiaomi Redmi 7a) and Android 14 (emulator). If anybody else also encounters this bug, please write your device model and OS version, we'd like to have as much info as possible.

akki42 commented 9 months ago

Just to make sure (sorry!): You did look in the favorite view / tab? (The filter works fine on both the contacts and the groups view / tab...)

Or another way to check: Unselect all sources. Are (any) favorites still shown in favorites view / tab?

Aga-C commented 9 months ago

Yes, I was checking in Favorites tab.

Aga-C commented 9 months ago

Do you also have this issue with contacts stored in Phone storage (not visible by other apps)? They are handled separately from other contacts, so I'm curious if these also show incorrectly.

akki42 commented 9 months ago

Do you also have this issue with contacts stored in Phone storage (not visible by other apps)? They are handled separately from other contacts, so I'm curious if these also show incorrectly.

Thanks for looking into this.

No, Phone storage (not visible by other apps) works correctly (favorite conact is not shown in favorites view when this source is not active).

Trying things out, I came across another oddity - no clue if this is related in any way (and / or specific to my devices as well): I have a number of "duplicate" contacts, which (1) I have both in a nextcloud account and as Signal (or Molly, a Signal clone) contact and (2) which are assigned to a group (e.g. "Family") in the nextcloud account. On the contacts view and with duplicates merging deactivated, both contact entries show the group ("Family") flag (and editing or deleting that flag in one of the contact entries also affects the other - even when that other entry is not even visible as it source is filtered / deactivated). On the groups view / tab, however, only the entry from nextcloud is shown. If nextcloud source is filtered / deactivated (from contacts or favorites view - there is no filter icon on group view), Family group is shown as empty "(0)". [The number of contacts in a group does not change immediately when filtering a source; you have to click on / open any group first...]

antodc commented 8 months ago

It may be OS specific, I couldn't reproduce it on my stock Android 13 (OnePlus 8 Pro), Android 10 (Xiaomi Redmi 7a) and Android 14 (emulator). If anybody else also encounters this bug, please write your device model and OS version, we'd like to have as much info as possible.

Same problem here. I have an Oscal C60 with Android 11.

Aga-C commented 8 months ago

@antodc Do you have stock Android OS or custom ROM?

antodc commented 8 months ago

@Aga-C No idea. The one pre-installed in that device.

Aga-C commented 8 months ago

@antodc So it's stock OS 🙂

antodc commented 8 months ago

@Aga-C Thank you! Good to know. 😊

Wurftaube commented 3 months ago

Galaxy S24 Ultra, Android 14 Stock ROM I have choosen the contacts of two accounts, merge contacts is off. In the contact view it works as expected, in the favorites view I have double contacts because the contacts of an unchecked account are shown. I think that's the same bug.

Babber commented 2 weeks ago

Same problem here. I run v1.1.0 from the F-Droid repo on GrapheneOS (Android 15). My device is Pixel 9 Pro.

Just in case this has not been mentioned yet: if I star a contact in the phone storage as Favorite, it gets starred also among my Signal contacts (Signal can see my contacts in the phone storage). So either both of them are starred or none. And as it is described above, even if I e.g. filter out my Signal contacts, starred contacts are shown doubled in the Favorites tab from both sources.

FossifyOrg / Contacts