Create groups from imported/existing contacts

contrapunctus-1 commented 4 months ago

Checklist

[X] I can reproduce the bug with the latest version given here.
[X] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
[X] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
[X] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected app version

v1.0.1

Affected Android/Custom ROM version

LineageOS 20 (Android 13)

Affected device model

OnePlus 9 Pro (LE2121)

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

Create contact groups and add contacts to them.
Reinstall Fossify Contacts.
Open the contact groups tab.

Expected behavior

Contact groups should be detected from existing contacts.

The groups are indeed present in the contacts storage, since exporting the contacts exports a CATEGORIES field for the groups.

Actual behavior

The contact groups list is blank.

As a workaround, the user can manually re-create the contact groups. The existing contacts as displayed as being part of the groups.

Screenshots/Screen recordings

No response

Additional information

I hope this form provides enough useful information over what was provided in https://github.com/FossifyOrg/Contacts/issues/95 to make the additional effort worth it :unamused:

Aga-C commented 4 months ago

The groups are indeed present in the contacts storage, since exporting the contacts exports a CATEGORIES field for the groups.

In which storage do you keep contacts? I tried it with phone storage, and as I can reproduce the bug (and the workaround step), when exporting there's no CATEGORIES field after reinstalling the app.

Also, something's off, because groups created in Fossify Contacts aren't visible in Google Contacts, when those created in Google are visible in Fossify. Seems like there's a lack of synchronization.

contrapunctus-1 commented 4 months ago

All my contacts are in DEVICE (i.e. visible to all apps).

Aga-C commented 4 months ago

Actually, I have to close this issue as wontfix. I did an investigation and in contacts the only information stored about the group is ID, so we have no possibility to recreate it properly. You can even check it that way, that if you reinstall the app, you don't need to name groups as they were originally; you can just assign them random names and contacts will appear in it.

To prevent this problem in the future, I've fixed a related problem, that it wasn't possible to choose where the group is saved and by default each group was private, therefore it was existing as long as the app wasn't uninstalled. Pull request is here: https://github.com/FossifyOrg/Contacts/pull/97.

contrapunctus-1 commented 4 months ago

@Aga-C Thanks. Will that mean that when contacts are imported, groups will also be imported from the CATEGORIES field? I really want to use groups, but the inability to import/export groups prevents me (and I have to resort to ugly hacks like putting categories in a name field).

Aga-C commented 4 months ago

Yes, contacts will be imported along with their groups.

FossifyOrg / Contacts