While investigating https://github.com/FossifyOrg/Contacts/issues/96, I've found out, that app wasn't allowing to create groups anywhere despite private storage and Google. It was strange, especially that groups were read from every possible contact source.
I don't know why it was done like this originally (dates back to 2018), but from my quick testing it seems, that it works correctly.
BTW. I see that groups feature is done a bit strange. I mean:
Wherever a group is stored, in a contact is always stored just an ID of the group.
It would be good if you could add to the group only contacts from the same source, but you can add contacts from any source. It may lead to ID conflicts.
Maybe that's why there was a source limiting? But it makes completely no sense that you could add any contact to a private group and this information is still stored there, even if you uninstall the app.
I have no idea how to solve it right now, so I left it as it is. But we may like to revise it in the future.
What is it?
Description of the changes in your PR
While investigating https://github.com/FossifyOrg/Contacts/issues/96, I've found out, that app wasn't allowing to create groups anywhere despite private storage and Google. It was strange, especially that groups were read from every possible contact source. I don't know why it was done like this originally (dates back to 2018), but from my quick testing it seems, that it works correctly.
BTW. I see that groups feature is done a bit strange. I mean:
Before/After Screenshots/Screen Record
https://github.com/FossifyOrg/Contacts/assets/85929121/4bf86b6c-1d1f-4091-b544-3604fc715faf
https://github.com/FossifyOrg/Contacts/assets/85929121/b6c46ba5-7727-4113-a4b6-1713ce55913e
Fixes the following issue(s)
Acknowledgement