FossifyOrg / Gallery

Browse your memories without any interruptions with this photo and video gallery
https://www.fossify.org
GNU General Public License v3.0
1.34k stars 41 forks source link

Only in Copy/Move Dialog: Some Software Keyboards Misbehave In Search Input #145

Open GfEW opened 4 months ago

GfEW commented 4 months ago

Checklist

Affected app version

1.1.1

Affected Android/Custom ROM version

Android 9 to 11

Affected device model

diverse

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

  1. In Fossify Gallery, mark any items (media files or folders) in any folder or flat view.
  2. In the three dots menu at the upper right, tap at "Copy to" or "Move to".
  3. In the dialog to select a destination, tap at the search line and type some characters
  4. Try to delete the last typed character or to move around pressing left arrow, right arrow, home or end keys.

Expected behavior

Pressing backspace should delete the character before the text cursor (if any), and pressing the cursor keys should move the text cursor around (within the typed characters).

Actual behavior

Cursor keys don't move the text cursor, and backspace may or may not delete the preceding character (depending on the particular keyboard app).

Screenshots/Screen recordings

No response

Additional information

Aga-C commented 4 months ago

I also tested on Simple Keyboard (soon to be Fossify Keyboard), and backspace works fine here too. It seems to be a problem with Hacker's keyboard and Unexpected keyboard, maybe their backspace implementation isn't standard and somehow relates to usage of arrows. Since backspace works on most popular keyboards and the problem is only with arrows, and they aren't that commonly used on software keyboards (they are often hidden), I tagged is as a niche problem. However, I can confirm the bug exists.

GfEW commented 4 months ago

Thanks for testing, and elaborating on the label, I can understand the decision.

Since search input in the Copy/Move destination chooser seems to behave in a few quirky ways that all other text input lines (including searches) in Fossify Gallery don't, I assume there's a different, single-use chunk of code at work - despite the very similar (if not identical) task.

Is there any reason the working generic search/filter code isn't reused there? Maybe those little "Only in Copy/Move destination chooser" issues would vanish all at once.

Patriclis commented 4 months ago

I do not have a third party software keyboard installed - using the default "Samsung Keyboard" that comes with my device - and am also experiencing this issue in the gallery app as well as the file manager app.

I've only tried with the backspace key, my arrows are hidden.

Gallery Version

1.1.1

File Manager Version

1.0.0

Device

Samsung Galaxy S20 FE

Keyboard

Samsung Keyboard Version 5.6.10.40

Additional Details

All other details are the same as the original ticket.