FossifyOrg / Gallery

Browse your memories without any interruptions with this photo and video gallery
https://www.fossify.org
GNU General Public License v3.0
1.59k stars 52 forks source link

Some colors do not render correctly after updading to 1.1.3 #202

Closed Vsnmrn closed 5 months ago

Vsnmrn commented 5 months ago

Checklist

Affected app version

1.1.3

Affected Android/Custom ROM version

Android 14

Affected device model

Samsung A54

How did you install the app?

GitHub releases

Steps to reproduce the bug

  1. Open the app
  2. Open the app settings
  3. Then open the about

Expected behavior

The colors should not have changed.

Actual behavior

Some colors render differently depending on whether you are in the app settings or in the about.

Screenshots/Screen recordings

At the left it is 1.1.2, at the right it is 1.1.3. The settings page does not change, it is the reference. (For exemple the titles in the about have a different color than the titles in the settings in 1.1.3)

image119

Additional information

I've found 2 similar problems here : https://github.com/FossifyOrg/Gallery/issues/94 https://github.com/FossifyOrg/General-Discussion/issues/85 But these issues where linked to the old orange accent color and are supposed to be fixed now.

naveensingh commented 5 months ago

The slight accent color difference between the about page and other pages are because of color tone variations between the XML theme and jetpack compose theme.

The about page was rewritten in jetpack compose a while ago, everything else still uses the view system.

But this difference should already be there in every Fossify app. Not just the Gallery.