In Editor after drawing on pictures the result is resized (shrinked) to screen dimensions

teastrainer commented 6 months ago

Checklist

[X] I can reproduce the bug with the latest version given here.
[X] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
[X] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
[X] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected app version

1.1.3

Affected Android/Custom ROM version

Android 13 / LineageOS 20

Affected device model

Xiaomi Pocophone F1

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

1) In gallery view tap on a picture (bigger than the screen size) 2) Tap on edit 3) Tap on draw (pencil at the righthand bottom corner) 4) Finish editing by clicking on the tick (at the top of the screen) a popup window opens with a save dialogue containing path, filename (with 1 appended) and extension

Expected behavior

The new picture is saved with the original dimensions.

Actual behavior

The image is saved with the edits, but the dimensions are reduced to fit the screen size of the device.

Screenshots/Screen recordings

No response

Additional information

An option could be to add the current dimensions in the save dialogue, editable to amend dimensions on purpose.

Aga-C commented 6 months ago

Actually, resolution is always changed. Pictures smaller than the screen size are enlarged to it after saving. You even don't need to draw anything.

quazgar commented 2 months ago

I can confirm this, and I find this quite severe since it results in data loss that is not immediately noticeable.

quazgar commented 2 months ago

I don't know any Kotlin, but to me the error seems to be that resizeImage() is called here (EditActivity.kt, line 506) where probably just the function reference (resizeImage) should have been passed?

FossifyOrg / Gallery