FossifyOrg / Gallery

Browse your memories without any interruptions with this photo and video gallery
https://www.fossify.org
GNU General Public License v3.0
1.59k stars 52 forks source link

Feature Request: Save without additional dialog #227

Open jtrees opened 4 months ago

jtrees commented 4 months ago

Checklist

Feature description

Saving changes to an image should be low-friction and seamless. There should be no additional save dialog. Changes to an image could simply be saved with a filename suffix, preserving the original.

Why do you want this feature?

I always find it quite jarring when I edit an image (e.g. rotate it) then tap "save" and the save dialog pops up. The stock gallery app on my phone provides a much more seamless experience.

Additional information

To keep things flexible, there could be additional options for configuration such as...

  1. Replacing the original file on save (#62)
  2. Using a customizable pattern for the new file name
  3. Disabling the "seemless save" feature entirely and sticking with the old dialog flow

... but (except maybe point 3) those probably shouldn't be considered in-scope for the issue at hand and could be implemented separately at a later time.

Aga-C commented 4 months ago

I think without save dialog should only be rotation. Other operations are destructible and users should be notified about it by save dialog.

jtrees commented 4 months ago

I think without save dialog should only be rotation. Other operations are destructible and users should be notified about it by save dialog.

Note that this feature request does not propose any "destructible" operations (like in #62). All changes are saved to a new file. The original is always preserved.

GfEW commented 1 day ago

@Aga-C

I think without save dialog should only be rotation. Other operations are destructible and users should be notified about it by save dialog.

I beg to differ on this one.

It's a rather common concept (if not default) that if you open a file, edit it and save it, you immediately overwrite the file with the edited version. By opening a file in an editor, you typically agree to this workflow. If you want to save your edits to a different file instead, you simply use the dedicated Save as ... button, shortcut or menu element. If you prefer to safeguard the risk of inadvertent saving, you can also enable backup copies.

This discrepancy already makes Fossify Gallery's compulsory "Save as ..." dialog enough of a nuisance it should be optional. If the user prefers, tapping the checkmark icon should suffice to immediately save the changes to the current file, just like pressing the "Save" button (or Ctrl+S etc.) in most text/image/audio/younameit editors does.

Alas, the compulsory "Save as ..." dialog is even more tedious in practice, since it, once you've tapped OK to confirm the existing name, always runs into the obvious "name conflict" that requires yet another moot tap at Yes to confirm the overwrite.

Requiring three taps for every single save-in-place operation is beyond reasonable if you (like me) edit pictures in place, anyway.

(And in the rare case I really mean to save my edits to a new file, there are viable other options:

thisisartman commented 1 day ago

100% agreed on everything above.

Akin to (a), Fossify Gallery could also offer both "Save" and "Save as ...", either by separate button or by overloading the existing one:

  • tap to "Save"
  • long-tap to "Save as ...".)

As for this, I'd like to suggest Google Photos' choices:

Screenshot_20241001-121513.png