FossifyOrg / General-Discussion

A place for discussing all apps in general plus anything else you want to say.
https://www.fossify.org
65 stars 3 forks source link

Use Material Design icons. #121

Closed RokeJulianLockhart closed 4 months ago

RokeJulianLockhart commented 4 months ago

Checklist

Which apps should have this feature?

All Fossify Apps

Feature description

Although at small sizes, your icons appear to be Material Design, at larger sizes, they noticeably differ. Primarily, they possess rounded corners which the official icons do not.

Why do you want this feature?

I'm rather a stickler for consistency, so to my knowledge this request is merely subjective (if they were markedly different, I would state that a user should not be expected to understand different icon sets) but I do believe that it would be an aesthetic improvement, especially now that Material You colouration has been implemented. I'm aware of https://m3.material.io/styles/icons/applying-icons#67978061-677b-4dfc-a632-dbc497ae0f3e, but your icons don't appear to look as they do.

Additional information

Additionally, were a proposal like https://github.com/FossifyOrg/General-Discussion/issues/4#issuecomment-1842073203 affirmed, this would decrease design complexity considerably.

naveensingh commented 4 months ago

They are material design icons, you can choose the fill type, and roundedness on the website.

Rounded: https://fonts.google.com/icons?icon.style=Rounded Sharp: https://fonts.google.com/icons?icon.style=Sharp

RokeJulianLockhart commented 4 months ago

https://github.com/FossifyOrg/General-Discussion/issues/121#issuecomment-1984893937

@naveensingh, apologies then. However, considering that they appear distinct from all else I've observed until now, have you chosen an unusual variant? I don't know whether the OS defines a style, but if so, using that would be a marked improvement.

naveensingh commented 4 months ago

@RokeJulianLockhart

I wouldn't call it unusual, I picked the rounded icons for all apps. Example: https://fonts.google.com/icons?selected=Material%20Symbols%20Rounded%3Alandscape%3AFILL%401%3Bwght%40400%3BGRAD%400%3Bopsz%4024

I don't know whether the OS defines a style, but if so, using that would be a marked improvement.

Not sure what you mean by that, you can enable themed icons in your device settings if you are running Android 13 or above.