FossifyOrg / General-Discussion

A place for discussing all apps in general plus anything else you want to say.
https://www.fossify.org
65 stars 3 forks source link

When selecting a backup location which is not a direct child of Internal, the user is coerced into granting access to its parent or ancestor instead #211

Open kaoneko opened 2 months ago

kaoneko commented 2 months ago

Checklist

Affected Android/Custom ROM version

Android 13 / LineageOS 20

Affected device model

Pixel 4a

How did you install the apps?

F-Droid / IzzyOnDroid

Which apps are affected?

Calendar, Contacts, Notes, possibly others

Steps to reproduce the bug

  1. Open e.g. Notes and then its Settings and scroll all the way down
  2. Tap Enable automatic backups
  3. Tap the Folder field and pick a folder that's not a direct child of Internal, e.g. Internal > Backups > Notes
  4. A screen titled Confirm folder access pops up saying

    Please allow accessing 'Internal/Backups' on the next screen by pressing 'Use this folder' at the bottom.

  5. After tapping OK the Android file picker opens at said location. A security-minded user will navigate to the folder they actually want to grant access to and tap USE THIS FOLDER followed by ALLOW
  6. The user is returned to the Fossify folder picker, while a toast shows up saying Wrong folder selected, please select path 'Internal/Backups'

Expected behavior

I always feel a bit silly answering these two questions, since it should be clear by now, so I'll let ChatGPT answer them.

Actual behavior

Screenshots/Screen recordings

The behavior was coincidentally showcased in the video in #131, where the user actually goes along with granting the Fossify app wider access. He then remarks under Expected behavior:

Also, in step 9, I expect to give Fossify Contacts/Calendar access only to the backup directory (Internal > Backups > Contacts in my case), not to its parent.

Although this was not the main point of the feature request (it was also not a bug report).

Additional information

If you pick e.g. Internal > Backups > Local > Fossify > Notes, you will also be asked to grant access to Internal/Backups, hence me also mentioning ancestors in addition to parents.

Possibly related: