FossifyOrg / General-Discussion

A place for discussing all apps in general plus anything else you want to say.
https://www.fossify.org
67 stars 3 forks source link

[Migration] Compose-first approach (all new layouts and long-term migration) #63

Open machiav3lli opened 10 months ago

machiav3lli commented 10 months ago

Checklist

Is your feature request related to a problem? Please describe.

Current code base is 100% Kotlin, but still uses the kinda-legacy Android layout views system.

Describe the solution you'd like

Using Jetpack Compose would ease working with layout options (e.g. Adapters/Recyclers, views designs FossifyOrg/Gallery#13) and allows dropping the use of some dependencies (e.g. FossifyOrg/Gallery#36).

Migrating the whole code at once is a relatively big project with a lot of sub-tasks (started to get the hang of it, after doing this for 3 projects). That's why it'd make sense at first to only (re)implement anything in Compose when it's being added or touched/modified.

If someone is willing to take on such task, I'm gladly available for discussion.

inson1 commented 10 months ago

@machiav3lli please add list with all apps, so we would know what is done and what isnt

Aga-C commented 10 months ago

@inson1 Why you need the list with apps? All of them need to be changed and the refactoring plan should be more specific, e.g. what first should be changed in Commons and then which places should be changed, but it's not limited to specific apps.

naveensingh commented 10 months ago

Yes, any new features should use Jetpack Compose.

Rewriting everything in compose is a lot of work, it's too soon to say anything but I think we'll start with settings in every app. The About page was recently rewritten using Compose.

inson1 commented 10 months ago

@Aga-C ofc plan should be more specific, but it would be good to see the progress in some nice way and people would easily know, where it was already done and if we missed something, they coud just file report.

Aga-C commented 10 months ago

@inson1 When the plan is done, then the list will also be done. Don't hurry things needlessly, it will only make a mess.