FossifyOrg / Keyboard

Easy keyboard for inserting all kinds of texts, special characters and numbers.
https://www.fossify.org
GNU General Public License v3.0
288 stars 25 forks source link

Add Chuvash layout #33

Closed tenextractor closed 5 months ago

tenextractor commented 8 months ago

What is it?

Description of the changes in your PR

Added Chuvash layout. String "Chuvash" is hardcoded for now, I think that needs to be fixed by changing https://github.com/FossifyOrg/Commons

Before/After Screenshots/Screen Record

image

Fixes the following issue(s)

Acknowledgement

Aga-C commented 8 months ago

String "Chuvash" is hardcoded for now

You can quickly add it by yourself in Commons in https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/res/values/strings.xml. When creating a pull request in Commons, please mention that it's for this one.

tenextractor commented 8 months ago

You can quickly add it by yourself in Commons in https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/res/values/strings.xml. When creating a pull request in Commons, please mention that it's for this one.

Thanks, that has been done: https://github.com/FossifyOrg/Commons/pull/38

tenextractor commented 7 months ago

When will this be merged?

Aga-C commented 7 months ago

Before Keyboard is released, all PRs will be merged. But I don't know when it will happen. Please be patient.

naveensingh commented 5 months ago

@tenextractor Do you speak these languages? I mean Chuvash, Hebrew and Esperanto.

tenextractor commented 5 months ago

Do you speak these languages? I mean Chuvash, Hebrew and Esperanto.

No, but I know their alphabets. The Hebrew and Esperanto layouts have been copied from Gboard, with minor changes, and the Chuvash layout is based on user feedback.

Also, please convert some of the less common characters into popup characters, it's always a good idea to fit all characters in 4 rows or under.

I had asked the user for feedback on whether to add the example layout on the left (Й У Ӳ К Е Ӗ...), but they requested a bigger layout with all the keys visible. All of those letters are important, and we can't fit them in 4 rows. Is there any reason we need to use only 4 rows? Many languages in Gboard use 5 or more rows, like Thai for example.

tenextractor commented 5 months ago

Shift and Backspace should use 15% of the available space as done in other layouts.

But this makes the keys in the bottom row narrower and harder to press accurately. If there are fewer keys in the 3rd row, bigger Shift and Backspace would be good, but both the 2nd and 3rd row have 11 keys, including Shift and Backspace.

One of the examples given (SwiftKey?) has the Shift and Backspace keys occupying just as much space as the other keys.

tenextractor commented 5 months ago

These characters are already there in the ?123 number layout. We don't need to duplicate them here.

The issue is that it's not feasible to add all the Chuvash letters in 4 rows, so a 5th row was added. But the 5th row only has 6 alphabet letters, so I added 4 symbols to balance the layout and allow all 10 digits to be accessible with popups.

If the digits aren't an issue, the symbols could be removed, but that would make the top row have only 6 keys.

naveensingh commented 5 months ago

4 rows aren't mandatory or anything, just a design choice. I think I'll just merge this now and update the layout as needed upon user feedback.